docs: document interceptor registration for non-REST calls #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBernstorff
changed the title
|
Formatting check succeeded! |
There was a problem hiding this comment.
Pull Request Overview
Documents the interceptor registration process for non-REST calls in the server. Key changes include:
- Clarifying the interceptor discovery methods with revised numbering.
- Adding a note on manual interceptor registration and its impact on non-REST operations.
Comment on lines
358
to
362
| Interceptors will be discovered in one of two ways: | ||
|
|
||
| 1) discovered from the Spring application context as existing Beans (can be used in conjunction with `hapi.fhir.custom-bean-packages`) or registered with Spring via other methods | ||
|
|
||
| or | ||
| 1) From the Spring application context as existing Beans (can be used in conjunction with `hapi.fhir.custom-bean-packages`) or registered with Spring via other methods | ||
| 2) Classes will be instantiated via reflection if no matching Bean is found | ||
|
|
There was a problem hiding this comment.
The section header incorrectly implies there are only two discovery methods, yet manual registration is discussed immediately after. Consider separating the manual registration note into its own clearly labeled section to improve clarity.
Copilot uses AI. Check for mistakes.
jkiddo
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents sharp edge re: interceptor registration (#641).