Skip to content

Conversation

@jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented May 11, 2025

…all versions

@jkiddo jkiddo requested review from Copilot and patrick-werner May 11, 2025 17:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors terminology configuration by removing R4-specific terminology handling and moving the configuration to apply across all versions. Key changes include:

  • Updating imports and tests in the R5 integration test.
  • Adding a new terminology configuration file for shared remote terminology support.
  • Removing redundant code in the R4 server configuration.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR5IT.java Added test for remote terminology validation and consolidated imports
src/main/java/ca/uhn/fhir/jpa/starter/terminology/TerminologyConfig.java Introduced shared terminology configuration with remote terminology service support
src/main/java/ca/uhn/fhir/jpa/starter/common/FhirServerConfigR4.java Removed duplicated remote terminology validation logic
Comments suppressed due to low confidence (2)

src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR5IT.java:157

  • [nitpick] The new test method 'testValidateRemoteTerminology' only asserts results for the remote validation. Consider adding assertions to validate the 'localResult' outcome to ensure full coverage of the behavior.
@Test
	void testValidateRemoteTerminology() {

src/main/java/ca/uhn/fhir/jpa/starter/terminology/TerminologyConfig.java:31

  • [nitpick] Consider extracting the magic number '0' into a named constant to improve readability and maintainability of the configuration code.
theValidationSupport.addValidationSupport(0, new RemoteTerminologyServiceValidationSupport(theFhirContext, remoteSystem.getUrl()));

@robogary
Copy link

Formatting check succeeded!

@jkiddo jkiddo merged commit ba0589c into hapifhir:master May 13, 2025
4 checks passed
@jkiddo jkiddo deleted the feature/remote-terminology-multiple-versions branch May 13, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants