Fix: Conversion MedicationRequest 30-40 unmapped fields #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corne
commented
Jun 27, 2025
| @@ -439,61 +436,4 @@ public void copyDomainResource(org.hl7.fhir.r4.model.DomainResource src, | |||
| .map(Extension30_40::convertExtension) | |||
| .forEach(tgt::addModifierExtension); | |||
| } | |||
|
|
|||
| public static org.hl7.fhir.r4.model.MedicationRequest convertMedicationRequest(org.hl7.fhir.dstu3.model.MedicationRequest src) throws FHIRException { | |||
There was a problem hiding this comment.
Moved to MedicationRequest30_40.java
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
============================================
+ Coverage 13.06% 13.07% +0.01%
- Complexity 35997 36044 +47
============================================
Files 2447 2447
Lines 722902 722917 +15
Branches 211376 211382 +6
============================================
+ Hits 94418 94543 +125
+ Misses 595845 595672 -173
- Partials 32639 32702 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Corne
force-pushed
the
MedicationRequestConversion3040
branch
from
91bc846 to
8153274
Compare
dotasek
requested changes
Jul 3, 2025
...s/src/main/java/org/hl7/fhir/convertors/conv30_40/resources30_40/MedicationRequest30_40.java
Show resolved
Hide resolved
...s/src/main/java/org/hl7/fhir/convertors/conv30_40/resources30_40/MedicationRequest30_40.java
Show resolved
Hide resolved
...s/src/main/java/org/hl7/fhir/convertors/conv30_40/resources30_40/MedicationRequest30_40.java
Show resolved
Hide resolved
...s/src/main/java/org/hl7/fhir/convertors/conv30_40/resources30_40/MedicationRequest30_40.java
Show resolved
Hide resolved
|
@dotasek can you have another look at this PR? All your remarks should have been processed |
grahamegrieve
requested changes
Jul 26, 2025
org.hl7.fhir.convertors/src/test/resources/medication_request_30_converted_to_40.json
Outdated
Show resolved
Hide resolved
…y/requester/basedon)
Corne
force-pushed
the
MedicationRequestConversion3040
branch
from
5860625 to
aa20966
Compare
|
@dotasek @grahamegrieve could this get another review please 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry for auto formatting, best to review with hide whitespace enabled)