FEATURE/MINOR: kubernetes-ingress: Add metrics service-specific metadata #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `controller.service.metrics.labels` and `controller.service.metrics.annotations` so that the metrics service can have its metadata templated using metadata not shared by the main service.
|
@dkorunic is it OK for the |
|
@mecampbellsoup Yes, because subject doesn't follow exactly our regular format, but it's not really important since I can easily rewrite it when merging. |
mecampbellsoup
deleted the
mc/kube-ingress/add-metrics-service-labels-and-annotations
branch
|
Thanks Dinko! If I subscribe to notifications on this will I get notified when this is included in a release? |
dkorunic
added a commit
that referenced
this pull request
Mar 20, 2024
Changes in kubernetes-ingress: - Add metrics service-specific metadata (#229) - Enable QUIC only for K8s 1.24 (#230) due to MixedProtocolLBService feature gate Signed-off-by: Dinko Korunic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
controller.service.metrics.labelsandcontroller.service.metrics.annotationsso that the metrics service can have its metadata templated using metadata not shared by the main service.