fix: structured lighthouse process management #283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves ENOENT errors when lighthouse subprocess fails by implementing: - **Structured IPC Communication**: Replace file-based error detection with JSON message protocol for lighthouse subprocess communication - **Custom Process Registry**: Functional lighthouse process manager with proper cleanup, monitoring, and global state management via globalThis - **Enhanced Error Handling**: Categorize retryable vs non-retryable errors with intelligent retry logic for network/timeout issues - **Comprehensive Monitoring**: Process stats API endpoint, stuck process detection, and graceful termination with SIGTERM/SIGKILL - **Shared Utilities**: Extract message parsing and error categorization to reusable util functions with proper type exports **Technical Improvements:** - Factory function pattern with `createLighthouseProcessRegistry()` - Consola logger integration for consistent user feedback - GlobalThis state management for singleton registry - Comprehensive test coverage (31 tests) for all functionality - Clean architecture with proper separation of concerns **API Changes:** - Added `/api/process-stats` endpoint for monitoring - Enhanced lighthouse task with structured message parsing - Proper type exports via main types.ts file
✅ Deploy Preview for unlighthouse-crux-api canceled.
|
harlan-zw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we run Lighthouse we run it in its own process, this is to allow it to fail gracefully without taking down the rest of the scans.
However, the management of these Lighthouse processes isn't exactly handled gracefully and may result in their being rogue Lighthouse processes.
This PR aims to solve that by adding a process management interface that hooks into the signals from the parent process, ensuring processes remain in sync.
We also implement safer and more granular messaging between the Lighthouse process and the parent process using a strict IPC format.