Removed lock acquiring for the method BlockCommitSigs.#4732
Open
Removed lock acquiring for the method BlockCommitSigs.#4732
Conversation
Frozen
force-pushed
the
fix/deadllck-block-commit-sigs
branch
from
200d508 to
75c715b
Compare
Frozen
force-pushed
the
fix/deadllck-block-commit-sigs
branch
from
75c715b to
e071ebd
Compare
Frozen
force-pushed
the
fix/deadllck-block-commit-sigs
branch
from
e071ebd to
616cdad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method FBFTLog uses lock internally, so it could cause deadlock. Moved lock acquiring down to the error handling.