Skip to content

Commit

Permalink
fix viveks comments
Browse files Browse the repository at this point in the history
Signed-off-by: Calvin Lee <[email protected]>
  • Loading branch information
cjlee1 committed Nov 16, 2024
1 parent 71cc833 commit 3ba72f8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,26 +1,29 @@
import React, { createContext, useContext, ReactNode, useCallback, useEffect, useMemo, useState } from 'react'
import type { ReactNode } from 'react'
import React, { createContext, useContext, useCallback, useEffect, useMemo, useState } from 'react'
import { isEqual } from 'lodash-es'
import { useAtom, atom } from 'jotai'
import {
import type {
ListCommitsOkResponse,
mergePullReqOp,
RepoRepositoryOutput,
TypesPullReq,
TypesPullReqActivity,
TypesPullReqChecks,
TypesPullReqStats,
TypesRuleViolations,
TypesRuleViolations
} from '@harnessio/code-service-client'
import {
mergePullReqOp,
useFindRepositoryQuery,
useGetPullReqQuery,
useListCommitsQuery,
useListPullReqActivitiesQuery
} from '@harnessio/code-service-client'
import { ExecutionState } from '@harnessio/views'
import type { ExecutionState } from '@harnessio/views'
import { normalizeGitRef } from '../../../utils/git-utils'
import { useGetSpaceURLParam } from '../../../framework/hooks/useGetSpaceParam'
import { useGetRepoRef } from '../../../framework/hooks/useGetRepoPath'
import { useParams } from 'react-router-dom'
import { PathParams } from '../../../RouteDefinitions'
import type { PathParams } from '../../../RouteDefinitions'
import useSpaceSSE from '../../../framework/hooks/useSpaceSSE'
import { usePRChecksDecision } from '../hooks/usePRChecksDecision'
import { SSEEvent } from '../../../types'
Expand Down
6 changes: 3 additions & 3 deletions packages/views/src/components/repo-summary-panel.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react'
import type { IconProps } from '@harnessio/canary'
import {
Text,
Icon,
Expand All @@ -8,8 +9,7 @@ import {
DropdownMenu,
DropdownMenuTrigger,
DropdownMenuContent,
DropdownMenuItem,
IconProps
DropdownMenuItem
} from '@harnessio/canary'

interface DetailsProps {
Expand All @@ -23,7 +23,7 @@ interface PageProps {
title: string
details: DetailsProps[]
timestamp?: string
onAddDescription: () => void
onAddDescription?: () => void
description?: string
}

Expand Down

0 comments on commit 3ba72f8

Please sign in to comment.