Switch to rustix from libc #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @notgull thanks for your PR! Could you rebase this onto master so that we can validate it passes on stable CI? Apologies, our CI wasn't functional when you submitted this. |
Xaeroxe
reviewed
Aug 30, 2023
This commit replaces the code using libc with equivalent code using rustix. In addition to safety, this move also removes the dependency on C code and replaces it with a syscall, which is much faster. This PR also adds `forbid(unsafe_code)`, so that this crate shows up as unsafe-free when processed in `cargo-geiger`. Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
|
@notgull this is failing on MacOS, please review the CI logs |
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the code using libc with equivalent code using rustix. In addition to safety, this move also removes the dependency on C code and replaces it with a syscall, which is much faster.
This PR also adds
forbid(unsafe_code), so that this crate shows up as unsafe-free when processed incargo-geiger.