Switch from dirs crate to cargo-team maintained home crate #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oherrala
force-pushed
the
from-dirs-to-home
branch
2 times, most recently
from
d2f7dc1
to
76f6a0f
Compare
oherrala
force-pushed
the
from-dirs-to-home
branch
from
76f6a0f
to
3d8662d
Compare
|
FWIW, I'm in favor of using the home crate instead of dirs because it's used in several other crates already. |
|
Apparently So for this use case we might need to either feature gate |
|
I'm fine with implementing the feature gate. Apologies, I was the one who brought dirs into which. I wasn't aware of this licensing issue. |
|
I've implemented my solution in #80. Thank you for bringing this issue to my attention! |
the-kenny
added a commit
to the-kenny/pgrx
that referenced
this pull request
Jan 24, 2024
The 'dirs' crate recently started depending on the 'options-ext' crate which uses copyleft license (MPL). This (unnecessary) dependency causes licensing issues for various users by possibly poisoning the dependency tree of their projects[1]. This change replaces the 'dirs' crate with 'home'. The 'home' crate is maintained by the cargo team and offers the same functionality. As a bonus, this change also results in a slightly smaller dependency tree. [1]: - artichoke/artichoke#2564 - pyrossh/rust-embed#231 - juhaku/utoipa#834 - harryfei/which-rs#78
the-kenny
added a commit
to the-kenny/pgrx
that referenced
this pull request
Jan 24, 2024
The `dirs` crate recently started depending on the `options-ext` crate which uses copyleft license (MPL). This (unnecessary) dependency causes licensing issues for various users by possibly poisoning the dependency tree of their projects[1]. This change replaces the `dirs` crate with `home`. The `home` crate is maintained by the cargo team and offers the same functionality. As a bonus, this change also results in a slightly smaller dependency tree. [1]: - artichoke/artichoke#2564 - pyrossh/rust-embed#231 - juhaku/utoipa#834 - harryfei/which-rs#78
the-kenny
added a commit
to the-kenny/pgrx
that referenced
this pull request
Apr 20, 2024
The `dirs` crate recently started depending on the `options-ext` crate which uses copyleft license (MPL). This (unnecessary) dependency causes licensing issues for various users by possibly poisoning the dependency tree of their projects[1]. This change replaces the `dirs` crate with `home`. The `home` crate is maintained by the cargo team and offers the same functionality. As a bonus, this change also results in a slightly smaller dependency tree. [1]: - artichoke/artichoke#2564 - pyrossh/rust-embed#231 - juhaku/utoipa#834 - harryfei/which-rs#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by a new dependency in
dirs-sys-rscrate (see dirs-dev/dirs-sys-rs@e169da7) and subsequent issues (see dirs-dev/dirs-sys-rs#21, dirs-dev/dirs-sys-rs#23 and dirs-dev/dirs-rs#51) where author ofdirscrate included new small crateoption-extwhich is licensed with MPL license. MPL can be problematic to users.This pull requests switches from
dirscrate tohomecrate.homecrate is maintained by the cargo team and is licensed with "MIT OR Apache-2.0" licenses including the one dependency.