Skip to content

ACTIN-1966 add range rank to MolecularMatchDetails #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArnoHMF
Copy link
Contributor

@ArnoHMF ArnoHMF commented May 12, 2025

See https://hartwigmedical.atlassian.net/browse/ACTIN-1966

In the OncoAct internal data model the affected Codon / affected Exon is passed on in a field called rangeRank. That naming I used here as well.

I did not see a way to get this information from the Serve datamodel (though it seems that it should be in there) so instead I pass it on from the Variant.

I'm not particularly happy with this solution, however I could not think of an alternative.

I did not add any tests yet as I first want to check if this is an acceptable solution, or if there are perhaps better alternatives before I spent more time on this approach

@ArnoHMF ArnoHMF requested review from kduyvesteyn and cbruel May 12, 2025 14:19
@ArnoHMF
Copy link
Contributor Author

ArnoHMF commented May 13, 2025

Discussed with Korneel: Best approach is to add this information back in Serve again (Korneel can you provide some input on how to do this) instead of passing the info from the variant deep into the ACTIN code.

The range rank will then still be returned through the MolecularMatchDetails. Question here is if rangeRank is the correct name?

@kduyvesteyn
Copy link
Contributor

Discussed with Korneel: Best approach is to add this information back in Serve again (Korneel can you provide some input on how to do this) instead of passing the info from the variant deep into the ACTIN code.

The range rank will then still be returned through the MolecularMatchDetails. Question here is if rangeRank is the correct name?

You'd have to make the following changes in datamodel:

  • Replace RangeAnnotation interface with CodonAnnotation and ExonAnnotation interfaces that take the extra fields that are currently in KnownCodon and KnownExon.
  • KnownCodon should extend CodonAnnotation rather than RangeAnnotation and drop additional fields.
  • KnownExon should extend ExonAnnotation rather than RangeAnnotation and drop additional fields
  • ActionableRange should be split up in ActionableCodon and ActionableExon similar to their known classes.

(Note that this should imply no change in fields for KnownExon and KnownCodon)

In terms of algo, every usage of ActionableRange should be refactored, and everywhere instances are created the inputTranscript, inputCodonRank and inputExonRank should be provided (didn't check the details but assume this won't be hard). For ref genome converter you could either wipe these 2 fields (since they don't convert) or keep them knowing that they are "input" parameters in the space of the ref genome that the source has been defined in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants