INFRA-1533: Add unit tests to Compar somatic variant comparison #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdenburger
approved these changes
Jun 20, 2025
| final List<SomaticVariantData> newVariants, final MatchLevel matchLevel) | ||
| { | ||
| boolean hasRefItems = refVariants != null; | ||
| boolean hasNewItems = newVariants != null; | ||
| final List<String> emptyDiffs = Lists.newArrayList(); |
There was a problem hiding this comment.
You could replace all "empty list variables" here with List.of(), which returns a reference to a single static empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some refactoring to make the it easier to test the most relevant parts of the code.
I'm not really happy about the amount of boilerplate in SomaticVariantDataTestFactory, but I couldn't think of a way with less boilerplate without just making all fields in SomaticVariantData mutable. Also, I would prefer to add a test for each field in SomaticVariantData that compare two variants that are only different in that single field, but I couldn't think of a way to do that in a reasonable amount of code.
Suggestions are welcome.