fix: refactor Python lint workflow to dynamically determine target projects and streamline directory handling #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects and streamline directory handling
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/python-lint-test.yml:25
- [nitpick] Consider using consistent naming conventions for job names. For example, using 'Find target projects' or 'find-target-projects' could improve clarity and consistency.
name: Find target Projects
| dispatch_inputs = "${{ github.event.inputs.target_projects }}"; | ||
| if (dispatch_inputs !== "") { | ||
| dispatch_inputs = dispatch_inputs.split(',').map(path => path.trim()); | ||
| core.setOutput('projects', JSON.stringify(dispatch_inputs)); |
There was a problem hiding this comment.
The script in the 'Get Python projects' step uses core.setOutput without importing the '@actions/core' module. Please import core at the beginning of the script to ensure it is defined.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
We can utilize the @actions/core library without the need for explicit imports. The core module is automatically provided as an argument to your script, allowing direct access to its functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes significant updates to the GitHub Actions workflow for Python linting and testing. The changes aim to improve the flexibility and efficiency of the workflow by introducing a new job to dynamically determine the target projects based on the changes in the pull request.
Key updates to the GitHub Actions workflow:
.github/workflows/python-lint-test.yml: Replaced thetarget_dirinput withtarget_projectsto specify the projects to run lint and test on..github/workflows/python-lint-test.yml: Added a new jobtarget_projectsto find the target projects by checking for changes in directories containingpyproject.tomlandMakefile..github/workflows/python-lint-test.yml: Updated the mainpython-lint-and-testjob to depend on thetarget_projectsjob and use a matrix strategy to run lint and test on each project found..github/workflows/python-lint-test.yml: Removed the old logic for determining changed directories and replaced it with a step to print the changed directories based on the output of thetarget_projectsjob..github/workflows/python-lint-test.yml: Simplified the steps for installing dependencies, linting, and testing by removing unnecessary condition checks and using the matrix strategy.