Feat/ml sandbox cmd #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to generate code suggestions for PR |
feat: create initial din.py file for model implementation
haru-256
force-pushed
the
feat/ml-sandbox-cmd
branch
from
0403d8c to
8a7e296
Compare
|
Failed to generate code suggestions for PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
job-runnerandml_sandbox_libsprojects, focusing on codebase restructuring, dependency updates, and type hint improvements. The most important changes are summarized below:Restructuring and Dependency Updates:
cmd/job-runner/main.py: Removed the oldSettingsclass and its dependencies.job_runner/pyproject.toml: Renamed fromcmd/job-runner/pyproject.toml, updated dependencies, and added build system configurations. [1] [2]job_runner/src/job_runner/main.py: Added a newJobRunnerclass to run jobs on Google Cloud AI Platform, including new environment variables and command-line arguments.Type Hint Improvements:
ml_sandbox_libs/src/ml_sandbox_libs/data/amazon_reviews_dataset.py: Added type hints to various methods, including__len__,__getitem__,train_dataloader,val_dataloader, andtest_dataloader. [1] [2] [3] [4] [5]Testing Enhancements:
ml_sandbox_libs/tests/test_utils/test_metrics.py: Added type hints to test functions and methods, such astest_create_classification_inputs,test_create_retrieval_inputs,test_mrr, andtest_hit_rate. [1] [2] [3] [4] [5] [6]ml_sandbox_libs/tests/test_utils/test_callbacks.py: Removed unnecessary context manager and updated imports. [1] [2]Configuration and Environment Updates:
.github/workflows/python-lint-test.yml: AddedFORCE_COLORenvironment variable for pytest and updated job configurations. [1] [2] [3]job_runner/samples/.env.local: Added new environment variables for the sample job runner configuration.Miscellaneous:
ml_sandbox_libs/pyproject.toml: Updated author information and added new mypy configurations. [1] [2]These changes collectively improve the structure, maintainability, and functionality of the codebase.