Skip to content

Migrate Tool Version Management to Mise #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Migrate Tool Version Management to Mise #40

merged 1 commit into from
Jul 15, 2025

Conversation

haru-256
Copy link
Owner

@haru-256 haru-256 commented Jul 15, 2025

User description

Summary

Migrate tool version management from the legacy .tool-versions file to mise.toml. This also updates the uv version from 0.6.14 to 0.7.20.

Related Issues

  • Nothing

Changes

  • migrate asdf to mise

How to Test

  • uv run pytest

Additional Context

  • Nothing

PR Type

Enhancement


Description

  • Remove .tool-versions configuration file.

  • Deprecate asdf tool version management.

  • Facilitate migration to mise.toml system.


Changes diagram

flowchart LR
  A[Old Tooling Config (.tool-versions)] --> B[New Tooling Config (mise.toml)]
Loading

Changes walkthrough 📝

Relevant files
Configuration changes
.tool-versions
Remove legacy tool version configuration                                 

.tool-versions

  • The .tool-versions file has been completely removed from the
    repository.
  • This change eliminates the explicit specification of uv version 0.6.14
    within this file.
  • It signifies a move away from asdf for tool version management.
  • +0/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Migrate tool version management from the legacy `.tool-versions` file to `mise.toml`. This also updates the `uv` version from 0.6.14 to 0.7.20.
    @haru-256 haru-256 requested a review from Copilot July 15, 2025 13:38
    Copy link
    Contributor

    @gemini-code-assist gemini-code-assist bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Summary of Changes

    Hello @haru-256, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

    This pull request modernizes the project's tool versioning system by transitioning from the legacy .tool-versions file to mise.toml. This update streamlines the management of development tools and includes an upgrade to a more recent version of the uv package installer.

    Highlights

    • Tool Version Management Migration: The project's tool version management has been migrated from using the .tool-versions file to mise.toml. This change standardizes how development tool versions are declared and managed within the repository.
    • Tool Version Update: The uv tool's version has been updated from 0.6.14 to 0.7.20 as part of the migration to mise.toml.
    Using Gemini Code Assist

    The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

    Invoking Gemini

    You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

    Feature Command Description
    Code Review /gemini review Performs a code review for the current pull request in its current state.
    Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
    Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
    Help /gemini help Displays a list of available commands.

    Customization

    To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

    Limitations & Feedback

    Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

    You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

    Footnotes

    1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

    Copy link
    Contributor

    @Copilot Copilot AI left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Pull Request Overview

    Migrate tool version management from the legacy .tool-versions to mise.toml, updating the uv runtime from 0.6.14 to 0.7.20.

    • Add mise.toml with new [tools] section specifying uv = "0.7.20"
    • Remove the uv entry from .tool-versions

    Reviewed Changes

    Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

    File Description
    mise.toml Added new tool configuration with updated version
    .tool-versions Removed legacy uv version entry
    Comments suppressed due to low confidence (2)

    mise.toml:1

    • Consider updating the project README or contributing guide to explain the new mise.toml configuration and migration steps for developers.
    [tools]
    

    @github-actions github-actions bot changed the title feat: Migrate from .tool-versions to mise.toml Migrate Tool Version Management to Mise Jul 15, 2025
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    🔀 No multiple PR themes
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    @gemini-code-assist gemini-code-assist bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Code Review

    This pull request migrates the project's tool version management from .tool-versions to mise.toml, and updates the uv tool from version 0.6.14 to 0.7.20. The change is straightforward and correct. My review includes one suggestion to also manage the Python version within mise.toml to improve development environment consistency.

    Comment on lines +1 to +2
    [tools]
    uv = "0.7.20"
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    medium

    To ensure a consistent development environment for all contributors, it's a good practice to also manage the Python version with mise. Most pyproject.toml files in the repository specify requires-python = ">=3.12", so pinning Python to a 3.12 version would be beneficial.

    This prevents potential issues from developers using different patch versions and centralizes tool version management in one place.

    [tools]
    python = "3.12"
    uv = "0.7.20"
    

    @haru-256 haru-256 merged commit 9de13af into main Jul 15, 2025
    3 checks passed
    @haru-256 haru-256 deleted the fix-use-mise branch July 15, 2025 13:41
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant