Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BBND-803] Limit extended from 10 to 1000 #402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BBND-803] Limit extended from 10 to 1000 #402

wants to merge 2 commits into from

Conversation

AlbertoMolinaIoBuilders
Copy link
Contributor

@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders commented Apr 3, 2025 •
edited
Loading

Description

Bug fixed

Fixes # (issue) 🛠️

Roles display in the Front end were limited to only 10 of them. Now extended to 1'000 (there should be plenty)

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Describe tests and instructions to reproduce. 🧪

  • Local Tests (npm run test)
  • Manual (CLI or web interface)
  • Local GitHub Actions (act pull_request)

Node version:

  • 18
  • 20
  • 22
  • 23

Test Results (if any)

Checklist

  • Style Guidelines followed ✅
  • Self-Reviewed 👀
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Effective Tests Added ✔️
  • Local Tests Pass ✅
  • No reduction of Coverage

@AlbertoMolinaIoBuilders
limit extended from 10 to 1000
dafbbed 
Signed-off-by: Alberto Molina <[email protected]>
@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders marked this pull request as ready for review April 3, 2025 09:08
@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders requested review from a team as code owners April 3, 2025 09:08
@MiguelLZPF MiguelLZPF added this to the Sprint 15 milestone Apr 4, 2025
@MiguelLZPF MiguelLZPF added Bug A error that causes the feature to behave differently than what was expected based on design docs Web Changes related to the “web” module labels Apr 9, 2025
@MiguelLZPF MiguelLZPF changed the title limit extended from 10 to 1000 [BBND-803] Limit extended from 10 to 1000 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelLZPF MiguelLZPF MiguelLZPF approved these changes

@ManuIOB ManuIOB ManuIOB approved these changes

@EMerchant90 EMerchant90 Awaiting requested review from EMerchant90 EMerchant90 is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Web Changes related to the “web” module
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbertoMolinaIoBuilders @MiguelLZPF @ManuIOB