Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move mocked revocation list #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor: Move mocked revocation list #409

wants to merge 1 commit into from

Conversation

MiguelLZPF
Copy link
Contributor

Description

Moved all mocks to a specific folder inside contracts/contracts/

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

  • Local Tests (npm run test)
  • Manual (CLI or web interface)
  • Local GitHub Actions (act pull_request)

Node version:

  • 18
  • 20
  • 22
  • 23

Test Results (if any)

Checklist

  • Style Guidelines followed ✅
  • Self-Reviewed 👀
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Effective Tests Added ✔️
  • Local Tests Pass ✅
  • No reduction of Coverage

@MiguelLZPF MiguelLZPF self-assigned this Apr 8, 2025
@MiguelLZPF MiguelLZPF added Improvement Code changes driven by non business requirements Contracts Changes related to the “contracts” module labels Apr 8, 2025
@MiguelLZPF MiguelLZPF added this to the Sprint 15 milestone Apr 8, 2025
@MiguelLZPF MiguelLZPF marked this pull request as ready for review April 8, 2025 10:08
@MiguelLZPF MiguelLZPF requested review from a team as code owners April 8, 2025 10:08
@MiguelLZPF MiguelLZPF requested a review from sergmetelin April 8, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders AlbertoMolinaIoBuilders approved these changes

@jaime-iobermudez jaime-iobermudez jaime-iobermudez approved these changes

@sergmetelin sergmetelin Awaiting requested review from sergmetelin sergmetelin is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

@MiguelLZPF MiguelLZPF

Labels
Contracts Changes related to the “contracts” module Improvement Code changes driven by non business requirements
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelLZPF @AlbertoMolinaIoBuilders @jaime-iobermudez