Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BBND-751] Domain data validation #412

Open
wants to merge 10 commits into
base: refactor/BBND-628-sdk
Choose a base branch
from
Open

[BBND-751] Domain data validation #412

wants to merge 10 commits into from

Conversation

iobroberto
Copy link
Contributor

Description

Add business logic validation to domain entities.

Fixes # (issue) 🛠️

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Describe tests and instructions to reproduce. 🧪

  • Local Tests (npm run test)
  • Manual (CLI or web interface)
  • Local GitHub Actions (act pull_request)

Node version:

  • 18
  • 20
  • 22
  • 23

Test Results (if any)

Checklist

  • Style Guidelines followed ✅
  • Self-Reviewed 👀
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Effective Tests Added ✔️
  • Local Tests Pass ✅
  • No reduction of Coverage

@iobroberto iobroberto added Improvement Code changes driven by non business requirements SDK Changes related to the “sdk” module labels Apr 10, 2025
@iobroberto iobroberto added this to the Sprint 15 milestone Apr 10, 2025
@iobroberto iobroberto self-assigned this Apr 10, 2025
@iobroberto
fix: add missing validations and improvements
0d2a462 
Signed-off-by: Roberto Delgado <[email protected]>
@iobroberto
chore: prettier
d5633ec 
Signed-off-by: Roberto Delgado <[email protected]>
@iobroberto iobroberto marked this pull request as ready for review April 10, 2025 08:10
@iobroberto iobroberto requested review from a team as code owners April 10, 2025 08:10
@iobroberto
chore: remove unused class
78552de 
Signed-off-by: Roberto Delgado <[email protected]>
@jaime-iobermudez
Copy link
Contributor

A general comment, have you performed regression testing on the web?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaime-iobermudez jaime-iobermudez jaime-iobermudez left review comments

@RaphaelMessian RaphaelMessian Awaiting requested review from RaphaelMessian RaphaelMessian is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

@iobroberto iobroberto

Labels
Improvement Code changes driven by non business requirements SDK Changes related to the “sdk” module
Projects
None yet
Milestone
Sprint 15
Development

Successfully merging this pull request may close these issues.
2 participants
@iobroberto @jaime-iobermudez