Open
Conversation
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
….ts` Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
…ge cases and improve safety Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
…andle edge cases and improve safety" This reverts commit ba6cb33. Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com> Signed-off-by: Alberto Molina <alberto@io.builders> Co-authored-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
- Enhanced commit-msg hook to verify/auto-add DCO sign-off - Added pre-push hook as final gate requiring both DCO + GPG - Created setup-git.sh script for developer onboarding - Updated CONTRIBUTING.md with setup instructions The enforcement layers: 1. pre-commit: lint-staged for code quality 2. commit-msg: DCO verification + auto-addition + commitlint 3. pre-push: blocks push without DCO + GPG signatures Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Reorganize the monolithic registry generator into a well-structured module with clear separation of concerns: Core Components: - extractor.ts: Contract metadata extraction from artifacts - scanner.ts: Filesystem scanning and contract discovery - generator.ts: Code generation logic (formerly registryGenerator.ts) - pipeline.ts: Main generation orchestration - types.ts: Centralized type definitions Utilities: - abiExtractor: ABI parsing and extraction - fileUtils: File I/O operations - logging: Structured logging - solidityParser: Comprehensive Solidity parser avoiding TypeChain Benefits: - Eliminated 6+ second TypeChain import overhead - Improved maintainability with single-responsibility modules - Better testability with isolated concerns - Flexible caching support via --use-cache flag - New npm script: npm run generate:registry:cached Infrastructure: - Updated barrel exports (index.ts files) - Cleaned up atsRegistry.data.ts (removed unused exports) - Updated CLI entry point with improved argument parsing - Enhanced logging capabilities - Updated integration tests Removed: - Old generateRegistry.ts monolithic entry point - Duplicated operations from infrastructure layer Reorganized files: - scripts/tools/generators/registryGenerator.ts → registry-generator/core/generator.ts - scripts/infrastructure/operations/generateRegistryPipeline.ts → registry-generator/pipeline.ts Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Migrate from ts-node with tsconfig-paths/register to tsx for faster, simpler TypeScript script execution. Remove redundant ts-node configuration from tsconfig.json since tsx handles path aliases natively. Changes: - packages/ats/contracts/package.json: Replace all ts-node invocations with tsx in CLI entry points (deploy*, upgrade*, generate:registry) - packages/ats/contracts/tsconfig.json: Remove ts-node configuration block - package.json: Add convenience scripts for contracts utilities exposed at root level (test:scripts:unit:parallel, test:scripts:integration:parallel, upgrade:previewnet, generate:registry, local:hardhat, size, slither, doc) Benefits: - Faster script execution with tsx (no tsconfig-paths dependency) - Simpler configuration (one less configuration block) - Better IDE integration and debugging support - Scripts available directly from monorepo root for convenience Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
The pre-push hook was incorrectly rejecting commits that had valid GPG signatures but whose public keys were not in the local keyring. This caused pushes to fail when rebasing from branches with commits signed by other team members. Changed from `git verify-commit` (requires public key) to `git log --format=%G?` which checks if a signature EXISTS without requiring verification. The hook now accepts any signature status except 'N' (no signature). Signed-off-by: Miguel Carpena <miguel.carpena@io.builders> Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Luigi Navarro <luigi@io.builders>
Signed-off-by: Luigi Navarro <luigi@io.builders>
- Updated @typechain/ethers-v5 from 10.2.1 to ^11.1.2 for improved type generation - Updated @typechain/hardhat from ^6.1.2 to ^6.1.6 for bug fixes and compatibility - Updated override constraint for @typechain/ethers-v5 to maintain version consistency - Added new npm script 'test:scripts:unit:coverage' to generate coverage reports for scripts directory with c8 Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Luigi Navarro <luigi@io.builders>
Signed-off-by: Luigi Navarro <luigi@io.builders>
Signed-off-by: Luigi Navarro <luigi@io.builders>
- Adopt Hiero naming convention (ddd-xxxx-name.yaml) with structured workflow names
- Standardize bash syntax: [[ ]] double brackets, == comparisons, ${VAR} braces
- Fix $GITHUB_OUTPUT quoting and ${{ always() }} expression syntax
- Simplify PR formatting triggers and fix assignee check security
- Delete obsolete backup workflow files
- Update cross-references in README.md, ci-cd-workflows.md, and CLAUDE.md
- Add GitHub Actions Workflow Standards section to CLAUDE.md
Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Replace legacy numeric timestamps with ISO format (YYYY-MM-DDTHH-MM-SS-sss) in all documentation, JSDoc, and CLI help text. Update newBlr workflow step counts from 8 to 10 to reflect Bond Fixed Rate, KPI Linked Rate, and SPT Rate configuration steps. Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
Signed-off-by: Marcos Serradilla Diez <marcos@io.builders>
Signed-off-by: Marcos Serradilla Diez <marcos@io.builders>
Add automated CI deployment testing and apply security/reliability improvements across all GitHub Actions workflows. Deployment Testing: - New 100-flow-ats-deployment-test.yaml with Hardhat + Hiero Solo jobs - Shared build job with dependency and artifact caching - Hiero Solo integration via hiero-solo-action v0.16.0 - Docker availability check for graceful Solo job skipping Workflow Hardening: - Upgrade actions/checkout v4.2.2 → v5.0.0 across all workflows - Pin actions/cache to v4.2.3 with commit SHA - Add timeout-minutes to all jobs (5/15/45 min by type) - Add defaults.run.shell: bash and concurrency controls - Add codecov action version annotation - Update npm to 11.7.0 in mass-payout publish Script Improvements: - Replace 195 parallel RPC calls with synchronous registry lookups - Wrap signer with NonceManager for nonce caching prevention - Add timing output to registry generation task - Fix ethers v6 API in diamondCutManager test - Add selector conflict validation test Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
… adjustBalances (#842) Signed-off-by: Marcos Serradilla Diez <marcos@io.builders>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: rbermejo <ruben@io.builders> Signed-off-by: Alberto Molina <alberto@io.builders> Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders> Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders> Signed-off-by: Miguel Carpena <miguel.carpena@io.builders> Signed-off-by: Ruben Martinez <ruben.martinez@io.builders> Signed-off-by: adrian <adrian@io.builders> Signed-off-by: Marcos Serradilla Diez <marcos@io.builders> Co-authored-by: Alberto Molina <alberto@io.builders> Co-authored-by: jaime-iobermudez <jaime.bermudez@io.builders> Co-authored-by: Miguel_LZPF <miguel.carpena@io.builders> Co-authored-by: Ruben Martinez <ruben.martinez@io.builders> Co-authored-by: adrian <adrian@io.builders> Co-authored-by: Marcos Serradilla Diez <marcos@io.builders> Signed-off-by: Ruben Martinez <ruben.martinez@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders> Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders> Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders> Signed-off-by: Miguel Carpena <miguel.carpena@io.builders> Signed-off-by: Ruben Martinez <ruben.martinez@io.builders> Signed-off-by: adrian <adrian@io.builders> Signed-off-by: Marcos Serradilla Diez <marcos@io.builders> Co-authored-by: Alberto Molina <alberto@io.builders> Co-authored-by: jaime-iobermudez <jaime.bermudez@io.builders> Co-authored-by: Miguel_LZPF <miguel.carpena@io.builders> Co-authored-by: Ruben Martinez <ruben.martinez@io.builders> Co-authored-by: adrian <adrian@io.builders> Co-authored-by: Marcos Serradilla Diez <marcos@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
Signed-off-by: jaime-iobermudez <jaime.bermudez@io.builders>
86e82cb to
ebe2a72
Compare
themariofrancia
approved these changes
Feb 27, 2026
themariofrancia
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements and improvements to the ATS Web App, focusing on bond tokenization features, UI/UX enhancements, and developer experience. The most significant changes include the addition of a comprehensive bond tokenization SDK, UI improvements with a loading overlay and fill form button, updated ESLint configuration for maintainability, and improvements to workflow and dependency management.
Bond Tokenization Features
apps/ats/web/CHANGELOG.mdapps/ats/web/CHANGELOG.mdR3-R20)UI/UX Enhancements
ProgressOverlay) to the security details page, including snapshot and unit tests, and updated i18n strings for progress steps. (apps/ats/web/src/components/ProgressOverlay.tsx[1]apps/ats/web/src/components/__tests__/ProgressOverlay.test.tsx[2]apps/ats/web/src/components/__tests__/__snapshots__/ProgressOverlay.test.tsx.snap[3]apps/ats/web/src/i18n/en/security/details.ts[4]apps/ats/web/src/views/CreateBond/Components/StepTokenDetails.tsx[1] [2]apps/ats/web/src/i18n/en/security/createBond.ts[3]apps/ats/web/src/i18n/en/security/equity/create.ts[4]apps/ats/web/src/views/CreateBond/__tests__/__snapshots__/CreateBond.test.tsx.snap[5]Developer Experience & Code Quality
@hashgraph/eslint-configpresets for base, React, and Jest, simplifying and standardizing linting rules. (apps/ats/web/eslint.config.mjsapps/ats/web/eslint.config.mjsL1-R24)package.jsonto use new linting scripts and added@hashgraph/eslint-configas a dev dependency. (apps/ats/web/package.json[1] [2]Workflow & Dependency Management
.github/workflows/102-flow-ats-deployment-test.yaml[1] [2]legacy-peer-deps=trueto.npmrcto resolve dependency issues during install. (.npmrc.npmrcR2)Form Handling Improvements
apps/ats/web/src/views/CreateBond/Components/StepReview.tsxapps/ats/web/src/views/CreateBond/Components/StepReview.tsxL134-R139)apps/ats/web/src/views/CreateBond/Components/StepReview.tsxapps/ats/web/src/views/CreateBond/Components/StepReview.tsxL289)These changes collectively enhance the functionality, usability, and maintainability of the ATS Web App.
Type of change
Testing
Node version:
Checklist