Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helm test subcommand with options #376

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: add helm test subcommand with options #376

merged 1 commit into from
Oct 5, 2023

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Sep 29, 2023 •
edited
Loading

Description

This pull request changes the following:

  • adds the helm test subcommand with filter and timeout options

PR Walkthrough (4 minutes): https://www.loom.com/share/3c18ac66fa4047f1ba25dfab7903b3eb?sid=3e98559a-b6cd-478d-bac3-bffb100c0edf

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Sep 29, 2023
@jeromy-cannon jeromy-cannon changed the base branch from main to 00323-gradle-helm-uninstall September 29, 2023 16:00
@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

Unit Test Results

21 files  +2  21 suites  +2   47s ⏱️ -4s
98 tests +3  94 ✔️ +3  4 💤 ±0  0 ❌ ±0 
99 runs  +3  95 ✔️ +3  4 💤 ±0  0 ❌ ±0 

Results for commit 572e900. ± Comparison against base commit ba6cc63.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon force-pushed the 00305-helm-client-test-subcommand branch from f5cced1 to d61a652 Compare October 2, 2023 16:13
@jeromy-cannon jeromy-cannon marked this pull request as ready for review October 2, 2023 16:16
@jeromy-cannon jeromy-cannon force-pushed the 00323-gradle-helm-uninstall branch 3 times, most recently from 458b7f5 to a2ef9fc Compare October 4, 2023 15:19
@jeromy-cannon jeromy-cannon force-pushed the 00305-helm-client-test-subcommand branch 2 times, most recently from 5861de4 to 65eb5fe Compare October 4, 2023 15:28
Base automatically changed from 00323-gradle-helm-uninstall to main October 5, 2023 13:35
@jeromy-cannon
Squashed commit of the following:
572e900 
commit 5f4d57c
Author: Jeromy Cannon <[email protected]>
Date:   Mon Oct 2 19:05:28 2023 +0100

    fix failing test case

    Signed-off-by: Jeromy Cannon <[email protected]>

commit d61a652
Author: Jeromy Cannon <[email protected]>
Date:   Mon Oct 2 16:53:14 2023 +0100

    test coverage

    Signed-off-by: Jeromy Cannon <[email protected]>

commit d813231
Author: Jeromy Cannon <[email protected]>
Date:   Fri Sep 29 16:58:16 2023 +0100

    testChart(String releaseName, TestChartOptions options)

    Signed-off-by: Jeromy Cannon <[email protected]>

commit c7aaf6c
Author: Jeromy Cannon <[email protected]>
Date:   Thu Sep 28 19:54:15 2023 +0100

    HelmUninstallChartTask code/examples/test coverage

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 6240d28
Author: Jeromy Cannon <[email protected]>
Date:   Wed Sep 27 17:18:35 2023 +0100

    fix test case failure

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 4a51c38
Author: Jeromy Cannon <[email protected]>
Date:   Wed Sep 27 14:47:16 2023 +0100

    removed todo for gradle plugin logging if error and added coverage for the same

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 834586d
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 21:15:39 2023 +0100

    gradle-executable path provided

    Signed-off-by: Jeromy Cannon <[email protected]>

commit c2cbdbf
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 20:52:32 2023 +0100

    gradle-executable path provided

    Signed-off-by: Jeromy Cannon <[email protected]>

commit a7540dc
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 18:35:14 2023 +0100

    gradle-executable shouldn't be needed...

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 480c288
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 18:12:35 2023 +0100

    supply gradle executable directory for new jobs

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 719b24b
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 18:03:21 2023 +0100

    supply gradle executable directory for new jobs

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 67e9c1c
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 17:39:47 2023 +0100

    Examples Spotless Check

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 9c40db5
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 17:35:06 2023 +0100

    update job ids for new jobs

    Signed-off-by: Jeromy Cannon <[email protected]>

commit c80aa8b
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 17:31:18 2023 +0100

    add compile and unit test jobs for examples project since they are now separate

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 4475c6a
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 17:21:14 2023 +0100

    updates based on feedback from Jendrick on hedera-services changes.

    Signed-off-by: Jeromy Cannon <[email protected]>

commit dd90490
Author: Jeromy Cannon <[email protected]>
Date:   Tue Sep 26 09:41:51 2023 +0100

    updates based on changes in helm install subcommand

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 6f436e6
Author: Jeromy Cannon <[email protected]>
Date:   Mon Sep 25 14:42:22 2023 +0100

    temporarily disable fullstack-examples until we can resolve intellij and sonar issues

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 962080e
Author: Jeromy Cannon <[email protected]>
Date:   Fri Sep 22 20:12:30 2023 +0100

    Squashed commit of the following:

    commit d177c82
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 21 19:02:43 2023 +0100

        updated HelmExecutionBuilder workingDirectory to use PWD instead of new File('.') from FileUtils

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 7ef57c1
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 21 14:09:23 2023 +0100

        removed commented out code that was previously used for shadowjars

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 4891dd5
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 20:02:40 2023 +0100

        remove shadowjars

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 9d67a54
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 19:48:24 2023 +0100

        remove shadowjars

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 3dc75a0
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 19:43:55 2023 +0100

        todo

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 7660afb
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 19:42:46 2023 +0100

        more todo's

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 51df393
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 18:04:31 2023 +0100

        switch to a different repo to avoid test collisions

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 44754c1
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 17:35:19 2023 +0100

        remove code smells

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit d068f26
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 16:25:05 2023 +0100

        updated HelmInstallChartTaskTest to different chart/repo to avoid collisions with other tests

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 7821d6f
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 13:10:07 2023 +0100

        add licenses at top of kotlin files

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit ae3d3c7
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 13:02:06 2023 +0100

        added TODO

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 4a82261
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 12:53:04 2023 +0100

        Revert "removed unneeded test implementation reference"

        This reverts commit 8eedff9.

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 674c155
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 12:49:28 2023 +0100

        removed unneeded test implementation reference

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 23c3104
    Author: Jeromy Cannon <[email protected]>
    Date:   Wed Sep 20 12:45:25 2023 +0100

        upcoming todo for next PR

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 72bf7b3
    Author: Jeromy Cannon <[email protected]>
    Date:   Tue Sep 19 22:26:19 2023 +0100

        removed commented out code

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit aec75d3
    Author: Jeromy Cannon <[email protected]>
    Date:   Tue Sep 19 22:24:54 2023 +0100

        FileUtils.getWorkingPath()

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 50e2a0e
    Author: Jeromy Cannon <[email protected]>
    Date:   Tue Sep 19 22:21:05 2023 +0100

        remove commented out code

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 659283b
    Author: Jeromy Cannon <[email protected]>
    Date:   Tue Sep 19 22:20:56 2023 +0100

        remove commented out code

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 5fb6e86
    Author: Jeromy Cannon <[email protected]>
    Date:   Tue Sep 19 22:20:30 2023 +0100

        added namespace and create namespace and example chart for installing during build check

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 6102441
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Sep 18 19:44:36 2023 +0100

        working version

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 7e06feb
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Sep 18 19:29:05 2023 +0100

        task working

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 19c176b
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Sep 18 19:06:37 2023 +0100

        non-working version

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 9e2e66f
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Sep 18 17:01:59 2023 +0100

        compiling version although not executing of moving integration tests into examples

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit c5a9b8a
    Author: Jeromy Cannon <[email protected]>
    Date:   Fri Sep 15 18:30:00 2023 +0100

        added logic to set the namespace in the helm install task

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit dc85197
    Author: Jeromy Cannon <[email protected]>
    Date:   Fri Sep 15 17:47:30 2023 +0100

        removed duplicate export

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 6710059
    Author: Jeromy Cannon <[email protected]>
    Date:   Fri Sep 15 17:28:10 2023 +0100

        added support for set and values parameters of install subcommand to handle sets

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 0d49686
    Author: Jeromy Cannon <[email protected]>
    Date:   Fri Sep 15 17:27:21 2023 +0100

        enhanced helm client to handle sets of strings for values and set parameters for the install subcommand

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 3f634e0
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 19:39:03 2023 +0100

        test nmt install

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit a760d52
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 19:06:12 2023 +0100

        update version from 0.7.0 to 0.8.0

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 3c2a99b
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 19:04:34 2023 +0100

        todo

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 77c59ef
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 18:57:51 2023 +0100

        removed comment from FullstackPlugin.java

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 840f64b
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 18:56:19 2023 +0100

        reordered alphabetically

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 28005ad
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 18:53:54 2023 +0100

        added set parameter

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 1d03540
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 18:32:07 2023 +0100

        update after merge from main made a mess (part2)

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit bb254c6
    Author: Jeromy Cannon <[email protected]>
    Date:   Thu Sep 14 18:26:36 2023 +0100

        update after merge from main made a mess

        Signed-off-by: Jeromy Cannon <[email protected]>

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 7c5b663
Author: Jeromy Cannon <[email protected]>
Date:   Mon Oct 2 17:07:26 2023 +0100

    better rename for options with multiple values

    Signed-off-by: Jeromy Cannon <[email protected]>

commit db5283d
Author: Jeromy Cannon <[email protected]>
Date:   Mon Sep 25 21:45:18 2023 +0100

    updates based on code review

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 72757ac
Author: Jeromy Cannon <[email protected]>
Date:   Mon Sep 25 13:40:35 2023 +0100

    sonar changes

    Signed-off-by: Jeromy Cannon <[email protected]>

commit d1b70f8
Author: Jeromy Cannon <[email protected]>
Date:   Fri Sep 22 19:55:41 2023 +0100

    coverage for ChartInstallRequest.apply()

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 622fd31
Author: Jeromy Cannon <[email protected]>
Date:   Fri Sep 22 19:55:13 2023 +0100

    spotlessApply

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 25ca488
Author: Jeromy Cannon <[email protected]>
Date:   Fri Sep 22 18:55:38 2023 +0100

    only %n for string.format

    Signed-off-by: Jeromy Cannon <[email protected]>

commit c9c45f9
Author: Jeromy Cannon <[email protected]>
Date:   Thu Sep 21 20:26:55 2023 +0100

    GMD: Enhance Helm Install to support multiple set and values parameters #366

    Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon force-pushed the 00305-helm-client-test-subcommand branch from 65eb5fe to 572e900 Compare October 5, 2023 13:40
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@jeromy-cannon jeromy-cannon merged commit 5d08a32 into main Oct 5, 2023
10 of 13 checks passed
@jeromy-cannon jeromy-cannon deleted the 00305-helm-client-test-subcommand branch October 5, 2023 16:07
swirlds-automation added a commit that referenced this pull request Nov 3, 2023
@swirlds-automation
chore(release): 0.12.0 [skip ci]
8c70660 
## [0.12.0](v0.11.0...v0.12.0) (2023-11-03)

### Features

* add a Gradle task for downloading executable for Kubernetes Kind ([#425](#425)) ([aaa9660](aaa9660))
* add fullstack-gradle-plugin project to GitHub workflow ([#421](#421)) ([7b717ab](7b717ab))
* add Gateway API route for Hedera Explorer ([#466](#466)) ([c53943c](c53943c))
* add Gradle build docker image tasks ([#408](#408)) ([338cf40](338cf40))
* add gradle Helm dependency update task  ([#393](#393)) ([8e3ead5](8e3ead5))
* add gradle Helm release exists task ([#389](#389)) ([0b7ae17](0b7ae17))
* add gradle Helm test task ([#403](#403)) ([591cebb](591cebb))
* add helm chart tests for gateway api routes ([#345](#345)) ([3936a64](3936a64))
* add helm dependency update subcommand ([#377](#377)) ([2b3609d](2b3609d))
* add helm execution gradle task: HelmInstallChartTask ([#304](#304)) ([6a29222](6a29222))
* add helm execution gradle task: HelmUninstallChartTask ([#375](#375)) ([ba6cc63](ba6cc63))
* add helm list releases subcommand ([#380](#380)) ([53d092f](53d092f))
* add helm test subcommand with options ([#376](#376)) ([5d08a32](5d08a32))
* add ifExists option to Gradle Helm uninstall task ([#405](#405)) ([0726725](0726725))
* add minio operator to fullstack-cluster-setup chart ([#453](#453)) ([bf7f6ff](bf7f6ff))
* add prometheus operator to fullstack-cluster-setup ([#460](#460)) ([0313c3a](0313c3a))
* add skipIfExists option for Gradle Helm install task ([#406](#406)) ([ccfbabf](ccfbabf))
* add support for scheduling pods based on node labels, taints, and affinity ([#352](#352)) ([5dd625a](5dd625a))
* Adding fabric8 k8s library and helm client for use in Infra API ([#386](#386)) ([3049fe4](3049fe4))
* Adding topology model classes and junit annotation processing ([#383](#383)) ([9c6930e](9c6930e))
* apply nodeSelector and tolerations to all pods including proxies ([#384](#384)) ([40e737a](40e737a))
* **cli:** add traceId in CLI logs for easier debugging ([#449](#449)) ([a1693c7](a1693c7))
* **cli:** implement chart install, uninstall and upgrade commands ([#454](#454)) ([70fd199](70fd199))
* **cli:** implement cluster create and delete commands ([#446](#446)) ([78be823](78be823))
* **cli:** implement cluster setup command ([#452](#452)) ([89c2662](89c2662))
* **cli:** implement tests and dependency checks for init command ([#438](#438)) ([b69dd99](b69dd99))
* enhance Helm Install to support multiple set and values parameters ([#367](#367)) ([05444df](05444df))
* implement fullstack-cluster-setup chart for shared resources ([#363](#363)) ([e91f465](e91f465))
* parameterize the helm chart namespace value ([#351](#351)) ([6d1c0a5](6d1c0a5))
* scaffold fsnetman CLI with ES6 support ([#424](#424)) ([65e06d9](65e06d9))
* upgrade to gradle 8.4 ([#404](#404)) ([69e769d](69e769d))
* upgrade to org.gradlex:java-module-dependencies:1.4.1 ([#365](#365)) ([ba7c32b](ba7c32b))

### Bug Fixes

* avoid hardcoding mirror-node-explorer rest API in values.yaml ([#413](#413)) ([0fe58c7](0fe58c7))
* **cli:** encapsulate helm and kubectl commands and code cleanup ([#476](#476)) ([1b8c499](1b8c499))
* **cli:** encapsulate Kind commands in a separate wrapper class ([#468](#468)) ([6dc6025](6dc6025))
* store hedera-explorer chart as dependency until next official version is released ([#436](#436)) ([201bda5](201bda5))
* support deploying the chart with custom release name ([#412](#412)) ([619b42b](619b42b))
* uninstall envoy-gateway should also remove gateway-system namespace that it created ([#350](#350)) ([8a2f6e1](8a2f6e1))
* update KeyValuePair.equals to only compare key (not value) ([#347](#347)) ([28222e0](28222e0))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy leninmehedy approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds

Assignees

@jeromy-cannon jeromy-cannon

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Client: Add support for the test subcommand
3 participants
@jeromy-cannon @swirlds-automation @leninmehedy