Optimized aggregation. New Index

Aggregation with single $match stage instead of multiple stages. Native to Mongo (no $where). More efficient use of indexes (+ new index added). Signed-off-by: Alexander Pyatakov <[email protected]>
hashgraph · Nov 11, 2024 · 76719f7 · 76719f7
1 parent ec878ea
commit 76719f7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/common/src/helpers/db-helper.ts b/common/src/helpers/db-helper.ts
@@ -481,20 +481,14 @@ export class DataBaseHelper<T extends BaseEntity> extends AbstractDataBaseHelper
                     $match: {
                         sent: true,
                         done: { $ne: true },
-                    },
-                },
-                {
-                    $addFields: {
-                        timeDifference: {
-                            $subtract: ['$processedTime', '$createDate'],
+                        $expr: {
+                            $gt: [
+                                { $subtract: ['$processedTime', '$createDate'] },
+                                processTimeout
+                            ]
                         },
                     },
                 },
-                {
-                    $match: {
-                        timeDifference: { $gt: processTimeout },
-                    },
-                },
             ],
         };
 

diff --git a/queue-service/src/entity/task.ts b/queue-service/src/entity/task.ts
@@ -1,8 +1,9 @@
-import { Entity, Property } from '@mikro-orm/core';
+import { Entity, Index, Property } from '@mikro-orm/core';
 import { ITask, WorkerTaskType } from '@guardian/interfaces';
 import { BaseEntity } from '@guardian/common';
 
 @Entity()
+@Index({ name: 'task_entity_idx', properties: ['sent', 'done', 'processedTime', 'createDate'] })
 export class TaskEntity extends BaseEntity implements ITask{
     @Property({nullable: true})
     userId: string | null;