fix: eth_getBlockByHash is using invalid cache record

[natanasow]

Description:

We are getting alerts on intermittent eth_getTransactionReceipt calls with a 500 response. Tracing through the logs we can see that the getBlockByHash call is missing a valid hash, right after the call to the mirror node on the contracts/results endpoint.

Steps to reproduce:

1. Look through the logs for an eth_getTransactionReceipt call with a 500 response.
2. Note the request ID and trace through the logs the path of the request.
3. Notice the call to getBlockByHash is missing a valid hash.

[34mDEBUG[39m (rpc-server/84 on mainnet-hashio-85fd789b7-twzsv): [36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] Validating method parameters for eth_getTransactionReceipt, params: ["0x411f2d52652ad237296f85041e382194d3fd5a7fb006e269975dede4652b70fc"][39m"
timestamp: "2024-11-11T15:30:19.138608570Z"

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] getTransactionReceipt(0x411f2d52652ad237296f85041e382194d3fd5a7fb006e269975dede4652b70fc)

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] [GET] contracts/results/0x411f2d52652ad237296f85041e382194d3fd5a7fb006e269975dede4652b70fc 200 4 ms

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] [GET] contracts/results/0x411f2d52652ad237296f85041e382194d3fd5a7fb006e269975dede4652b70fc 200 2 ms

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] getBlockByHash(hash=0x, showDetails=false)

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] [GET] blocks/NaN 400 status

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] Failed to retrieve block for hash 0x

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] Error invoking RPC: Invalid parameter: hashOrNumber

[36m[Request ID: 51841ec6-3dc9-4dad-af6a-07c4c3f01e02] [POST]: eth_getTransactionReceipt 500 20 ms

Related issue(s):

Fixes #3250

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

 17 files  ±0  230 suites  ±0   29m 20s ⏱️ +18s
607 tests ±0  603 ✅ ±0  4 💤 ±0  0 ❌ ±0 
623 runs  ±0  619 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 764079b. ± Comparison against base commit 3dd36f6.

♻️ This comment has been updated with latest results.

[ebadiere]

LG.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (3dd36f6) to head (764079b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3254      +/-   ##
==========================================
- Coverage   78.80%   77.84%   -0.96%     
==========================================
  Files          48       66      +18     
  Lines        3595     4460     +865     
  Branches      836     1000     +164     
==========================================
+ Hits         2833     3472     +639     
- Misses        423      613     +190     
- Partials      339      375      +36     

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	78.58% <100.00%> (+0.07%)	⬆️
server	83.28% <ø> (?)
ws-server	36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts	86.16% <100.00%> (+0.09%)	⬆️

... and 19 files with indirect coverage changes