-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added gas deviation to the release-light tests. #3264
Conversation
Signed-off-by: Eric Badiere <[email protected]>
Test Results 19 files - 1 248 suites - 9 31m 31s ⏱️ - 1m 52s For more details on these failures, see this check. Results for commit 54ad715. ± Comparison against base commit d1a8fbc. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some improvement suggestions.
Also please update the description, there's some changes that does seem related and might relate to other issues that need to be highlighted.
Signed-off-by: Eric Badiere <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3264 +/- ##
==========================================
- Coverage 83.17% 75.00% -8.18%
==========================================
Files 66 22 -44
Lines 4314 916 -3398
Branches 843 172 -671
==========================================
- Hits 3588 687 -2901
+ Misses 483 191 -292
+ Partials 243 38 -205
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR adds a gas deviation to the gas price in the
@release-light
tests, and removes some warnings in the IDE.Related issue(s):
Fixes #3259
Checklist