Lazy load nested items during contract call #7953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e lazy loaded Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
IvanKavaldzhiev
added
performance
web3
…ons, improve equals and hashCode Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7953 +/- ##
=============================================
+ Coverage 64.28% 92.21% +27.92%
- Complexity 219 7249 +7030
=============================================
Files 75 894 +819
Lines 2453 29225 +26772
Branches 48 3561 +3513
=============================================
+ Hits 1577 26949 +25372
- Misses 837 1455 +618
- Partials 39 821 +782 ☔ View full report in Codecov by Sentry. |
steven-sheehy
requested changes
Mar 25, 2024
...c/main/java/com/hedera/mirror/web3/evm/store/contract/HederaEvmStackedWorldStateUpdater.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Account.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Account.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Account.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Account.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Token.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Token.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Token.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Token.java
Outdated
Show resolved
Hide resolved
...-web3/src/test/java/com/hedera/mirror/web3/evm/store/accessor/TokenDatabaseAccessorTest.java
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <[email protected]>
… models Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
steven-sheehy
requested changes
Mar 26, 2024
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Account.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/services/store/models/Token.java
Outdated
Show resolved
Hide resolved
...or-web3/src/test/java/com/hedera/mirror/web3/evm/store/contract/HederaEvmWorldStateTest.java
Outdated
Show resolved
Hide resolved
steven-sheehy
changed the title
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
…ing-for-db-accessors
Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
…ing-for-db-accessors
…ing-for-db-accessors
…ead of synchronized block Signed-off-by: IvanKavaldzhiev <[email protected]>
IvanKavaldzhiev
dismissed stale reviews from kselveliev and steven-sheehy
via
9b16908
hedera-mirror-web3/src/main/java/com/google/common/base/Suppliers.java
Outdated
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
…ing-for-db-accessors
Signed-off-by: IvanKavaldzhiev <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
steven-sheehy
requested changes
Apr 12, 2024
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/utils/Suppliers.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/utils/Suppliers.java
Outdated
Show resolved
Hide resolved
...or-web3/src/main/java/com/hedera/mirror/web3/evm/store/accessor/AccountDatabaseAccessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <[email protected]>
…ing-for-db-accessors
Signed-off-by: IvanKavaldzhiev <[email protected]>
|
steven-sheehy
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances db accessors' performance by lazy loading some of the nested fields, which are not always directly used when fetching the models.
Related issue(s):
Fixes #7903
Notes for reviewer:
To be tested with acceptance and K6 tests
Checklist