Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an application cache for REST API #9626

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Add an application cache for REST API #9626

merged 6 commits into from
Nov 1, 2024

Conversation

jnels124
Copy link
Contributor

Description:

  • implement application cache

Related issue(s):

Fixes #9111

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jnels124
implement application cache
04afe11 
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 added enhancement Type: New feature rest Area: REST API labels Oct 23, 2024
@jnels124 jnels124 added this to the 0.117.0 milestone Oct 23, 2024
@jnels124 jnels124 self-assigned this Oct 23, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (d1b41f1) to head (4502d4f).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
hedera-mirror-rest/server.js 50.00% 3 Missing ⚠️
hedera-mirror-rest/cache.js 85.71% 2 Missing ⚠️
...era-mirror-rest/middleware/responseCacheHandler.js 98.38% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9626      +/-   ##
============================================
+ Coverage     92.22%   92.33%   +0.11%     
+ Complexity     7609     7505     -104     
============================================
  Files           932      917      -15     
  Lines         31940    31833     -107     
  Branches       4029     4042      +13     
============================================
- Hits          29456    29393      -63     
+ Misses         1535     1495      -40     
+ Partials        949      945       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnels124
add additional tests
71cdf96 
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124
add snyk exception
70e2719 
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124
cleanup tests
b57e33b 
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 marked this pull request as ready for review October 23, 2024 23:30
@jnels124 jnels124 requested a review from a team October 23, 2024 23:30
xin-hedera
xin-hedera requested changes Oct 25, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
hedera-mirror-rest/cache.js Outdated Show resolved Hide resolved
hedera-mirror-rest/__tests__/application.yml Outdated Show resolved Hide resolved
hedera-mirror-rest/middleware/metricsHandler.js Outdated Show resolved Hide resolved
hedera-mirror-rest/model/cachedApiResponse.js Outdated Show resolved Hide resolved
hedera-mirror-rest/middleware/responseCacheHandler.js Outdated Show resolved Hide resolved
hedera-mirror-rest/middleware/responseCacheHandler.js Outdated Show resolved Hide resolved
hedera-mirror-rest/middleware/responseCacheHandler.js Outdated Show resolved Hide resolved
@steven-sheehy steven-sheehy modified the milestones: 0.117.0, 0.118.0 Oct 28, 2024
@jnels124 jnels124 marked this pull request as draft October 28, 2024 22:21
@jnels124 jnels124 force-pushed the jtn-9111-add-an-application-cache-for-rest-api branch from f8aff3b to 9eb7188 Compare October 29, 2024 15:10
@jnels124
address pr feedback
801ea03 
Signed-off-by: Jesse Nelson <[email protected]>
@jnels124 jnels124 force-pushed the jtn-9111-add-an-application-cache-for-rest-api branch from 9eb7188 to 801ea03 Compare October 29, 2024 15:21
@jnels124 jnels124 marked this pull request as ready for review October 29, 2024 15:36
xin-hedera
xin-hedera previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 requested a review from a team October 30, 2024 19:29
@jnels124
move regex to constant
4502d4f 
Signed-off-by: Jesse Nelson <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

xin-hedera
xin-hedera approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnels124 jnels124 merged commit 0e2fa17 into main Nov 1, 2024
35 checks passed
@jnels124 jnels124 deleted the jtn-9111-add-an-application-cache-for-rest-api branch November 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xin-hedera xin-hedera xin-hedera approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

Assignees

@jnels124 jnels124

Labels
enhancement Type: New feature rest Area: REST API
Projects
None yet
Milestone
0.118.0
Development

Successfully merging this pull request may close these issues.

Add an application cache for REST API
3 participants
@jnels124 @steven-sheehy @xin-hedera