Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/coinbase/rosetta-sdk-go from 0.8.6 to 0.8.7 in /hedera-mirror-rosetta #9726

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps github.com/coinbase/rosetta-sdk-go from 0.8.6 to 0.8.7.

Release notes

Sourced from github.com/coinbase/rosetta-sdk-go's releases.

Update docs to mesh, add header forwarding

Docs update

We publicly renamed Rosetta to Mesh, this release contains all the docs updates for that rename

Header Forwarding

Why

In order to support some common use cases, Mesh servers need the ability to pass request headers through to the native nodes, and to return headers from native node requests back to the caller.

Use cases:

  • passing a client ID header to the nodes — this client ID shouldn't originate with the Mesh server since it may have many different callers, so it should be passed through to the native node requests
  • sticky session cookies — to support sticky sessions on native nodes, AWS uses cookies. Cookies are managed by the Cookie and Set-Cookie headers, which will need to be passed from the caller to the native node, and returned from the native node ALB to the caller

Solution

The HeaderForwarder type extracts headers from Mesh requests and forwards them to native node requests. It also watches potentially many native node responses and combines those headers to add them to a Mesh response.

To accomplish this, HeaderForwarder offers three different types of injection:

  • Server handler middleware — used to capture headers from the Mesh request for outgoing header forwarding, and to add native node response headers to the Mesh response
  • http.RoundTripper implementation — used to add outgoing headers to HTTP requests and capture incoming response headers
  • grpc.UnaryClientInterceptor implementation — used to add outgoing metadata to gRPC requests and capture incoming response metadata

A few key features:

  • opt-in — users of this library can choose to use or not use this feature
  • allows forwarding only specific headers
  • assigns every request a unique ID, which is used to associate headers from native node responses back to Mesh request/responses

Changelog

Full changelog: v0.8.5...v0.8.7

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/coinbase/rosetta-sdk-go](https://github.com/coinbase/rosetta-sdk-go) from 0.8.6 to 0.8.7.
- [Release notes](https://github.com/coinbase/rosetta-sdk-go/releases)
- [Commits](coinbase/mesh-sdk-go@v0.8.6...v0.8.7)

---
updated-dependencies:
- dependency-name: github.com/coinbase/rosetta-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Type: Pull requests that update a dependency file go labels Nov 11, 2024
@dependabot dependabot bot requested a review from a team as a code owner November 11, 2024 02:14
@steven-sheehy steven-sheehy modified the milestone: 0.118.0 Nov 11, 2024
@steven-sheehy steven-sheehy marked this pull request as draft November 11, 2024 18:54
…n /hedera-mirror-rosetta (#9610)"

This reverts commit d1b41f1.

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera marked this pull request as ready for review November 11, 2024 19:47
@xin-hedera xin-hedera added this to the 0.118.0 milestone Nov 11, 2024
Copy link

sonarcloud bot commented Nov 11, 2024

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (89eb806) to head (f20715d).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9726   +/-   ##
=========================================
  Coverage     92.23%   92.23%           
  Complexity     7628     7628           
=========================================
  Files           937      937           
  Lines         32121    32119    -2     
  Branches       4070     4071    +1     
=========================================
- Hits          29626    29625    -1     
  Misses         1542     1542           
+ Partials        953      952    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xin-hedera xin-hedera merged commit 15f8244 into main Nov 11, 2024
34 checks passed
@xin-hedera xin-hedera deleted the dependabot/go_modules/hedera-mirror-rosetta/github.com/coinbase/rosetta-sdk-go-0.8.7 branch November 11, 2024 21:20
bilyana-gospodinova pushed a commit that referenced this pull request Nov 18, 2024
…a-mirror-rosetta (#9726)

* Bump github.com/coinbase/rosetta-sdk-go in /hedera-mirror-rosetta

Bumps [github.com/coinbase/rosetta-sdk-go](https://github.com/coinbase/rosetta-sdk-go) from 0.8.6 to 0.8.7.
- [Release notes](https://github.com/coinbase/rosetta-sdk-go/releases)
- [Commits](coinbase/mesh-sdk-go@v0.8.6...v0.8.7)

---
updated-dependencies:
- dependency-name: github.com/coinbase/rosetta-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Revert "Bump github.com/coinbase/rosetta-sdk-go from 0.8.5 to 0.8.6 in /hedera-mirror-rosetta (#9610)"

This reverts commit d1b41f1.

Signed-off-by: Xin Li <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants