Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry incomplete address book during acceptance tests (0.118) #9749

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Cherry pick #9744 to release/0.118

Related issue(s):

Fixes #9743

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Nov 12, 2024
@steven-sheehy steven-sheehy added this to the 0.118.0 milestone Nov 12, 2024
@steven-sheehy steven-sheehy self-assigned this Nov 12, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner November 12, 2024 16:57
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (08bb610) to head (b173aee).
Report is 1 commits behind head on release/0.118.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/0.118    #9749      +/-   ##
===================================================
- Coverage            92.23%   92.22%   -0.02%     
+ Complexity            7628     7451     -177     
===================================================
  Files                  937      914      -23     
  Lines                32119    31499     -620     
  Branches              4071     4020      -51     
===================================================
- Hits                 29625    29049     -576     
+ Misses                1542     1514      -28     
+ Partials               952      936      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit d2abb21 into release/0.118 Nov 12, 2024
34 checks passed
@steven-sheehy steven-sheehy deleted the 9743-retry-address-book-118 branch November 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants