Change numbers to ids #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add HCS state proto Signed-off-by: Michael Tinker <[email protected]> * Add running hash, delete EntityNumber Signed-off-by: Michael Tinker <[email protected]> * add account and token * add account and token * add token * add tokenRelation * add some javadocs * add some javadocs * address review comments * fix missing import * address comments * address review comments * Update services/state/token/account.proto Co-authored-by: Richard Bair <[email protected]> * Update services/state/token/account.proto Co-authored-by: Richard Bair <[email protected]> * address some review comments * move back under services * change package name * some docs and revert java package name * revert docs * add javadocs * add javadocs * re-order the first 16 --------- Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Co-authored-by: Richard Bair <[email protected]>
* 265 - file proto Signed-off-by: Lev Povolotsky <[email protected]> * 265 - packaging Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments Signed-off-by: Lev Povolotsky <[email protected]> --------- Signed-off-by: Lev Povolotsky <[email protected]>
* change allowances * change allowances * change allowances * change allowances * change allowances * change allowances
* 265 - file proto Signed-off-by: Lev Povolotsky <[email protected]> * 265 - packaging Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments fix Signed-off-by: Lev Povolotsky <[email protected]> --------- Signed-off-by: Lev Povolotsky <[email protected]>
* add missing fields and change allowance names * change to bits * address review comments * address review comments * address review comments
* Add bytecode and storage slot representations Signed-off-by: Michael Tinker <[email protected]> * Add Nft type Signed-off-by: Michael Tinker <[email protected]> * Add EntityNumber Signed-off-by: Michael Tinker <[email protected]> * Use bytes instead of Int256Value Signed-off-by: Michael Tinker <[email protected]> * Fix typo Signed-off-by: Michael Tinker <[email protected]> * Remove superfluous Int256Value type Signed-off-by: Michael Tinker <[email protected]> * Rename Id -> UniqueTokenId Signed-off-by: Michael Tinker <[email protected]> * Don't store code_hash, can be cached on load Signed-off-by: Michael Tinker <[email protected]> --------- Signed-off-by: Michael Tinker <[email protected]>
* Added state for blocks and running hashes Signed-off-by: jasperpotts <[email protected]> --------- Signed-off-by: jasperpotts <[email protected]> Co-authored-by: jasperpotts <[email protected]>
Neeharika-Sompalli
requested review from
iwsimon and
MarcKriguerAtHedera
and removed request for
a team
Neeharika-Sompalli
assigned jasperpotts, rbair23, tinker-michaelj and mhess-swl and unassigned jasperpotts, rbair23, tinker-michaelj and mhess-swl
Neeharika-Sompalli
requested review from
rbair23,
tinker-michaelj and
mhess-swl
and removed request for
a team,
iwsimon and
MarcKriguerAtHedera
rbair23
previously approved these changes
Jun 9, 2023
mhess-swl
previously approved these changes
Jun 9, 2023
nathanklick
dismissed stale reviews from mhess-swl and rbair23
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all numbers to IDs