Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Retry in case of throttle when calling getRecord #1135

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Retry in case of throttle when calling getRecord #1135

merged 1 commit into from
Nov 13, 2024

Conversation

0xivanov
Copy link
Contributor

Description:

Related issue(s):

Fixes #1125

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the bug Something isn't working label Nov 13, 2024
@0xivanov 0xivanov self-assigned this Nov 13, 2024
@0xivanov 0xivanov requested review from a team as code owners November 13, 2024 08:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (962a404) to head (509269c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
transaction_response.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
+ Coverage   73.40%   73.44%   +0.03%     
==========================================
  Files         181      181              
  Lines       23105    23108       +3     
==========================================
+ Hits        16961    16971      +10     
+ Misses       5392     5384       -8     
- Partials      752      753       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gsstoykov
gsstoykov approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can rerun the CI integration tests a couple of times just to be safe.

@0xivanov 0xivanov merged commit cfbca81 into main Nov 13, 2024
12 of 13 checks passed
@0xivanov 0xivanov deleted the 1125-fix-THROTTLED_AT_CONSENSUS-for-getRecord branch November 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth is a code owner automatically assigned from hashgraph/hedera-sdk

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan is a code owner automatically assigned from hashgraph/hedera-sdk-go-maintainers

@agadzhalov agadzhalov Awaiting requested review from agadzhalov agadzhalov is a code owner automatically assigned from hashgraph/hedera-sdk-go-maintainers

Assignees

@0xivanov 0xivanov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix THROTTLED_AT_CONSENSUS for getRecord
2 participants
@0xivanov @gsstoykov