Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Init client with mirror network #1137

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 13, 2024

Description:

Related issue(s):

Fixes #1126

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the enhancement New feature or request label Nov 13, 2024
@0xivanov 0xivanov self-assigned this Nov 13, 2024
@0xivanov 0xivanov requested review from a team as code owners November 13, 2024 12:23
Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (a665a42) to head (4e18619).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   73.44%   73.45%           
=======================================
  Files         181      181           
  Lines       23108    23119   +11     
=======================================
+ Hits        16971    16981   +10     
- Misses       5384     5385    +1     
  Partials      753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

client.go Show resolved Hide resolved
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

note:
This could be tested with Solo when the time comes

@0xivanov 0xivanov merged commit e68b269 into main Nov 14, 2024
12 of 13 checks passed
@0xivanov 0xivanov deleted the 1126-add-method-to-NodeClient-for-Initialization-with-MirrorNetwork-only branch November 14, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to automatically query for an AddressBook if a Client is initialized only with a mirrorNetwork
2 participants