Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Data race in topic message query #787

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

bamzedev
Copy link
Contributor

@bamzedev bamzedev commented Aug 14, 2023

Description:
This PR fixes data race in TopicMessageQuery.

Related issue(s):

Fixes #786

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@bamzedev bamzedev force-pushed the fix/data-race-in-topic-message-query branch from 39670a3 to 84623ad Compare August 14, 2023 13:07
@bamzedev bamzedev requested a review from rokn August 14, 2023 13:16
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 67.94% and project coverage change: +0.09% 🎉

Comparison is base (3f01d98) 61.67% compared to head (a2a2bcd) 61.77%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #787      +/-   ##
===========================================
+ Coverage    61.67%   61.77%   +0.09%     
===========================================
  Files          164      164              
  Lines        33602    33679      +77     
===========================================
+ Hits         20723    20804      +81     
+ Misses       11587    11581       -6     
- Partials      1292     1294       +2     
Files Changed Coverage Δ
contract_id.go 69.61% <62.85%> (-1.62%) ⬇️
account_id.go 65.86% <65.71%> (+0.76%) ⬆️
topic_message_query.go 91.42% <100.00%> (+0.35%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bamzedev bamzedev force-pushed the fix/data-race-in-topic-message-query branch from 84623ad to 8a8c9fd Compare August 14, 2023 15:51
@bamzedev bamzedev force-pushed the fix/data-race-in-topic-message-query branch from 8a8c9fd to a2a2bcd Compare August 14, 2023 15:52
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bamzedev bamzedev merged commit 0ba653f into develop Aug 14, 2023
7 checks passed
@bamzedev bamzedev deleted the fix/data-race-in-topic-message-query branch August 14, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrency issues within TopicMessageQuery
2 participants