feat: Implement MirrorNodeContractQuery
#2073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
0xivanov
changed the title
MirrorNodeContractQuery MirrorNodeContractQuery
Nana-EC
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Nice start.
Missing some fields.
Also you might be able to leverage some Mirror Node web3 module tests as references of example calls.
@kselveliev should be able to help
| String hexData = Hex.toHexString(data); | ||
| return String.format(""" | ||
| { | ||
| "data": "%s", |
There was a problem hiding this comment.
Also missing from
Note from is also optional in the case we're simulating a contract create flow in which the data contains contract bytecode
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
kselveliev
reviewed
Nov 14, 2024
sdk/src/main/java/com/hedera/hashgraph/sdk/MirrorNodeContractQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Ivanov <[email protected]>
kselveliev
reviewed
Nov 14, 2024
| .execute(testEnv.client); | ||
|
|
||
| var contractId = Objects.requireNonNull(response.getReceipt(testEnv.client).contractId); | ||
|
|
0xivanov
commented
Nov 14, 2024
| @@ -40,7 +42,7 @@ | |||
| /** | |||
| * Utility class used internally by the sdk. | |||
| */ | |||
| class EntityIdHelper { | |||
| public class EntityIdHelper { | |||
There was a problem hiding this comment.
note:
Made this class public in order to access it from the tests, changed most public methods to package private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A new
MirrorNodeContractQueryis added to support EVM gas estimation and simulation. The inputs should match that ofContractExecuteTransactionas devs will be looking to calculate the cost of a follow up transaction.This query issues an
api/v1/contracts/callto the mirror node web3 module that support estimate and simulation of state changing transactions.Related issue(s):
Fixes #2076
Notes for reviewer:
Checklist