feat: Pull protos from services #2611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
+ Coverage 84.71% 84.84% +0.13%
==========================================
Files 283 284 +1
Lines 71086 71309 +223
==========================================
+ Hits 60218 60503 +285
+ Misses 10868 10806 -62 ☔ View full report in Codecov by Sentry. |
ivaylogarnev-limechain
requested review from
dalvizu,
jeromy-cannon,
rwalworth,
ivaylonikolov7,
0xivanov,
agadzhalov and
gsstoykov
0xivanov
reviewed
Oct 25, 2024
Signed-off-by: ivaylogarnev-limechain <[email protected]>
jeromy-cannon
previously approved these changes
Oct 29, 2024
rbarkerSL
previously approved these changes
Oct 30, 2024
…gnore Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
dismissed stale reviews from rbarkerSL, jeromy-cannon, agadzhalov, and 0xivanov
via
2fdbe34
Signed-off-by: ivaylogarnev-limechain <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We need to migrate the protobuf definitions from the hedera-protobufs repository to pull from the hedera-services repository. This change is aimed at simplifying the development process and centralizing all Protobuf-related files directly within the hedera-services repo, ensuring they stay in sync with service code.
Related issue(s):
Fixes #
#2572
Checklist