feat: Add node AccountId to timeout/max attempt errors
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttemts/timeout errors, unit tests added Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
… purposes Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
feat/consensus-node-id-on-error
branch
from
4ca4350
to
a0d9b98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
+ Coverage 84.81% 84.89% +0.08%
==========================================
Files 284 285 +1
Lines 71281 71486 +205
==========================================
+ Hits 60457 60690 +233
+ Misses 10824 10796 -28 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…o file Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
requested review from
rwalworth,
ivaylonikolov7,
0xivanov,
agadzhalov and
gsstoykov
0xivanov
changed the title
AccountId to timeout/max attempt errors
0xivanov
reviewed
Nov 12, 2024
Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…TimeoutError nodeId to string Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…h/hedera-sdk-js into feat/consensus-node-id-on-error
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances error handling by including the consensus node ID in error messages related to connection issues, such as timeouts and max attempts, during transaction processing.
Related issue(s):
#2597
Checklist