Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added NodeInfoError class and refactored a bit Executable max a… #2637

Closed
wants to merge 1 commit into from

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR enhances error handling by including the consensus node ID in error messages related to connection issues, such as timeouts and max attempts, during transaction processing.

Related issue(s):
#2597

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ttemts/timeout errors, unit tests added

Signed-off-by: ivaylogarnev-limechain <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 89.94709% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (0444d08) to head (49a065c).

Files with missing lines Patch % Lines
src/NodeInfoError.js 76.92% 15 Missing ⚠️
src/Executable.js 50.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0444d08) and HEAD (49a065c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0444d08) HEAD (49a065c)
3 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   84.78%   78.56%   -6.23%     
==========================================
  Files         284      285       +1     
  Lines       71253    71440     +187     
==========================================
- Hits        60414    56127    -4287     
- Misses      10839    15313    +4474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant