-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift example for managing NFT allowances #400
Add Swift example for managing NFT allowances #400
Conversation
Signed-off-by: b-l-u-e <[email protected]>
Requesting for assistance on testing this one @hendrikebbers |
Hi @b-l-u-e, thank you for your PR. In Note: Run |
@RickyLB thank you for reaching out to me.. let me add AddNftAllowance in exampleTargets |
@RickyLB just made changes |
829b83c
to
c3f7033
Compare
Signed-off-by: b-l-u-e <[email protected]>
A good way to test the example would be to create a testnet account in hedera portal account, and fill a new
Apologize, I should have included this earlier to help you with testing your example. |
Signed-off-by: b-l-u-e <[email protected]>
@RickyLB requesting for a review made some changes based on your review |
@RickyLB any updates? |
@b-l-u-e please check the CI build errors; they will tell you why it's failing. Also, it may help to install Swift 6.0.2 on your local machine (Windows or linux) so you can view these errors quicker. |
Signed-off-by: b-l-u-e <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging!
Description:
By adding an example to demonstrate how to manage NFT allowances in the Swift SDK.
The example includes step-by-step processes for:
Testing:
Related issue(s):
Fixes #385: Add example: Add and remove NFT allowances
Notes for reviewer:
Checklist