Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for flexible lease acquisition and production readiness #830

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: add support for flexible lease acquisition and production readiness #830

wants to merge 9 commits into from

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Enhances leases to support additional edge cases where the lease can be automatically transitioned or renewed
  • Adds user, host, and process information and validation to the lease
  • Simplifies some logic and make classes more unit testable
  • Prepares lease classes to support IoC/DI containers
  • Moves leases closer to being production ready
  • Clearly separates Listr support from the core lease functionality
  • Improves handling of renewals and makes the renewal logic pluggable

Outstanding Work Remaining

  • Add additional unit test coverage
  • Add TSDoc/JSDoc comments and additional inline code comments
  • Verify actual solo commands still behave as expected with similar output

Related Issues

@nathanklick nathanklick added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone. labels Nov 14, 2024
@nathanklick nathanklick self-assigned this Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Unit Test Results - Linux

  1 files   35 suites   3s ⏱️
 95 tests  95 ✅ 0 💤 0 ❌
104 runs  104 ✅ 0 💤 0 ❌

Results for commit f34f3aa.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   35 suites  ±0   15s ⏱️ -2s
 95 tests ±0   95 ✅ ±0  0 💤 ±0  0 ❌ ±0 
104 runs  ±0  104 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7452b65. ± Comparison against base commit 1fa1d78.

♻️ This comment has been updated with latest results.

instamenta
instamenta previously approved these changes Nov 14, 2024
View reviewed changes
leninmehedy
leninmehedy reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@leninmehedy leninmehedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Added some nitpiks that may make the code a bit more readable. Since it is in DRAFT more, I would like do another review when it is ready.

src/core/lease.ts Show resolved Hide resolved
src/core/lease.ts Outdated Show resolved Hide resolved
src/core/lease.ts Outdated Show resolved Hide resolved
src/core/lease.ts Outdated Show resolved Hide resolved
src/core/lease_renewal.ts Outdated Show resolved Hide resolved
test/e2e/integration/core/lease.test.ts Show resolved Hide resolved
src/core/constants.ts Show resolved Hide resolved
jeromy-cannon
jeromy-cannon reviewed Nov 14, 2024
View reviewed changes
src/core/lease.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon left review comments

@leninmehedy leninmehedy leninmehedy left review comments

@instamenta instamenta instamenta left review comments

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

At least 1 approving review is required to merge this pull request.

Assignees

@nathanklick nathanklick

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leases: Support flexible lease acquisition
4 participants
@nathanklick @leninmehedy @jeromy-cannon @instamenta