Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for flexible lease acquisition and production readiness #830

Merged
merged 29 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
02cfced
feat: add support for flexible lease acquisition and production readi…
nathanklick Nov 13, 2024
ec6f27c
fix: resolve errors in main method
nathanklick Nov 14, 2024
912bf0c
fix: resolve issues with missing constructor arguments
nathanklick Nov 14, 2024
f6d89be
fix: node keys command should not acquire a lease
nathanklick Nov 14, 2024
1d6bbf8
fix: handle cases where the namespace does not exist (deploy, etc)
nathanklick Nov 14, 2024
7fbe85f
fix: resolve issues causing failures
nathanklick Nov 14, 2024
a988bc8
fix: minor tweaks for message consistency and stability
nathanklick Nov 14, 2024
7b6ea19
chore: implement reviewer comments
nathanklick Nov 14, 2024
fab57e2
chore: additional reviewer feedback
nathanklick Nov 14, 2024
9bfd34c
chore: move leasing packages into a subfolder
nathanklick Nov 18, 2024
3b2668d
fix: resolve constructor arguments
nathanklick Nov 18, 2024
b44e5d3
chore: handle case where we are doing cluster setup and we have clust…
jeromy-cannon Nov 19, 2024
794d362
chore: need to still have a config manager populated after reset is p…
jeromy-cannon Nov 19, 2024
538ab9f
chore: remove before delete namespace which causes hook failures in p…
jeromy-cannon Nov 19, 2024
71478b4
chore: update constructor ordering
nathanklick Nov 18, 2024
6459dc2
chore: add typescript documentation
nathanklick Nov 18, 2024
c7b0be9
chore: Revert "remove before delete namespace which causes hook failu…
jeromy-cannon Nov 19, 2024
5485b26
chore: update namespace for test to not conflict
jeromy-cannon Nov 19, 2024
01606b7
chore: expect(await instead of await expect(
jeromy-cannon Nov 19, 2024
31f46dd
chore: add additional jsdoc comments
nathanklick Nov 20, 2024
654b15a
chore: fix e2e pem tests
nathanklick Nov 20, 2024
e3ae0f6
chore: additional test fixes
nathanklick Nov 20, 2024
baecaa0
chore: switch from swc to tsc, switch from ts-node to tsx. this give…
jeromy-cannon Nov 20, 2024
1c5e502
chore: fix test case
jeromy-cannon Nov 20, 2024
43d0171
chore: no longer need .ts-node
jeromy-cannon Nov 20, 2024
342a3e2
chore: improve test debugging
nathanklick Nov 20, 2024
f1dd5d5
removed ts-node files and no longer need to convert ts to js files
jeromy-cannon Nov 20, 2024
ea6501f
swith from ts-node to tsc
jeromy-cannon Nov 20, 2024
07751b0
chore: fix help output
nathanklick Nov 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 8 additions & 53 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,55 +1,8 @@
name: Bug Report
description: File a bug report
title: "<Please write a short description of what didn't work for you here>"
#title: "<Please write a short description of what didn't work for you here>"
labels: ["Bug", "Pending Triage"]
body:
- type: input
id: bom-cli-version
attributes:
label: Bill of Materials or CLI Version
description: Which version of the BOM or CLI are you using?
placeholder: |
ex. 0.18.2 or git commit ID

The bill of materials version can be found in your Gradle or Maven
build configuration. The CLI version can be found by using the `--version` switch.
- type: dropdown
id: execution-environment
attributes:
label: Execution Environment
description: Which front-end execution environment are you using?
options:
- JUnit Extensions
- Performance CLI
- Local Node CLI
- Other
validations:
required: true
- type: dropdown
id: logging-implementation
attributes:
label: Slf4j Logging Implementation
description: Which slf4j compatible logging implementation are you using? **JUnit Users Only**
options:
- Log4j 1.x
- Log4j 2.x
- Logback Classic
- Other
validations:
required: false
- type: textarea
id: reproduction-steps
attributes:
label: To Reproduce
description: Steps to reproduce the behavior
render: markdown
placeholder: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
validations:
required: true
- type: textarea
id: actual-behavior
attributes:
Expand All @@ -67,13 +20,15 @@ body:
validations:
required: true
- type: textarea
id: test-cli-logs
id: reproduction-steps
attributes:
label: Whole JUnit/CLI Logs
description: "NEVER EVER OMIT THIS! Include logs from JUnit test output or CLI console/log file output. Don't omit the parts you think irrelevant!"
render: shell
label: To Reproduce
description: Steps to reproduce the behavior
placeholder: |
PROVIDE THE LOGS VIA A GIST LINK (https://gist.github.com/), NOT DIRECTLY IN THIS TEXT AREA
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
validations:
required: true
- type: textarea
Expand Down
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/feature_enhancement.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Feature Enhancement
description: Enhance an existing feature
title: "<Please write a brief description of the feature enhancement here>"
#title: "<Please write a brief description of the feature enhancement here>"
labels: ["Feature Enhancement", "Pending Triage"]
body:
- type: textarea
Expand All @@ -18,7 +18,6 @@ body:
attributes:
label: Requested Enhancement
description: What would you like to enhance or change about this feature?
render: markdown
placeholder: |
_A clear and concise description of what you want to happen._

Expand All @@ -30,7 +29,6 @@ body:
attributes:
label: Business Need
description: Why is this needed?
render: markdown
placeholder: |
_A clear and concise description of any alternative solutions or other features you've considered._

Expand Down
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
name: New Feature
description: Request a new feature
title: "<Please write a brief description of the new feature here>"
#title: "<Please write a brief description of the new feature here>"
labels: ["New Feature", "Pending Triage"]
body:
- type: textarea
id: feature-description
attributes:
label: Requested Feature
description: What would you like added?
render: markdown
placeholder: |
_A clear and concise description of what you want to happen._

Expand All @@ -20,7 +19,6 @@ body:
attributes:
label: Business Need
description: Why is this needed?
render: markdown
placeholder: |
_A clear and concise description of any alternative solutions or features you've considered._

Expand Down
8 changes: 6 additions & 2 deletions .mocharc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ verbose: true
file:
- test/setup.ts
require:
- ts-node/register
- test/setup.ts
extension:
- ts
loader: ts-node/esm
node-option:
- 'enable-source-maps'
- 'import=tsx'
full-trace: true
enable-source-maps: true
ui: bdd
18 changes: 0 additions & 18 deletions .swcrc

This file was deleted.

2 changes: 1 addition & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default [
"@typescript-eslint/consistent-type-imports": ["error", { fixStyle: 'inline-type-imports'}],
'space-before-function-paren': 'error',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/class-literal-property-style': 'off'
'@typescript-eslint/class-literal-property-style': 'off',
}
},
{
Expand Down
Loading
Loading