feat: 🎸 Add ability to search other resources as well #3021
+179
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For pages that have tables that display data from associates resources, we currently retrieve each associated resource 1 by 1 for each shown row to get the associated data and are unable to search columns that source data that doesn't exist in the primary table.
This PR adds the ability to search across multiple tables with joins. This allows us to search across multiple tables in the case where we have columns that use data from different resources. This does however force a dependency on us to load all the associated resources first as compared to making individual
GET
requests for each associated resource. But this is likely better than making all those GET requests at once (especially if they choose 50 items per page).The main downside is there can be a noticeable increase in latency for the searches depending on the number of resources.
Screenshots (if appropriate)
Example with 400k aliases + 400k targets and searching between all the resources in both tables.
Before:
Screen.Recording.2025-10-01.at.6.10.41.PM.mov
After:
Screen.Recording.2025-10-01.at.6.13.51.PM.mov
How to Test
Go to the aliases page and try searching target names or alias IDs. It should search across both resources.
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have addeda11y-tests
label to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.