chore: 🤖 use hds keyvalue component #3027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: 🤖 key value migration test: 💍 refactor tests fix: 🐛 vars, tests fix: 🐛 test fix: 🐛 include custom label fix: 🐛 empty key/value fix: 🐛 filter logic fix: 🐛 comment fix: 🐛 comments refactor: 💡 comments and helper method chore: 🤖 undo file change
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
reviewed
Oct 10, 2025
ui/admin/tests/integration/components/form/field/key-value-test.js
Outdated
Show resolved
Hide resolved
ui/admin/app/components/form/credential-library/vault-ssh-certificate/index.hbs
Show resolved
Hide resolved
Co-authored-by: Cristiano Rastelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://hashicorp.atlassian.net/browse/ICU-17397
This PR migrates to use hds key value inputs component.
Note: This pr only migrates a couple of forms with
textandselectinputs. The remaining forms will be migrated once this pattern is established.Screenshots (if appropriate)
sample error :
No change in response
critical options with data
critical options without data
account_claims_map with data
account_claims_map without data
How to Test
Checklist
[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have addeda11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.