chore: 🤖 add ipc handlers for rdp #3031
Open
+235
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 chore: 🤖 undo ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 fix: 🐛 logs ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 fix: 🐛 logs ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 fix: 🐛 logs ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 chore: 🤖 move up ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876 chore: 🤖 comment ✅ Closes: https://hashicorp.atlassian.net/browse/ICU-17876
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // RDP Client Configuration | ||
| const RDP_CLIENTS = [ | ||
| { | ||
| name: 'Microsoft Remote Desktop', |
There was a problem hiding this comment.
Do we need the name property here ? May be we can move the name to the translations and consumers can use the value property as key and get the corresponding translation.
| if (!preferredClient) { | ||
| // Auto-detect and set the best available client | ||
| preferredClient = await this.getBestDefaultRdpClient(); | ||
| if (preferredClient !== 'none') { |
There was a problem hiding this comment.
Wondering if we need this check i.e preferredClient !== 'none' ? Asking because if a user selects "none" option as their preferred client, then in the below setPreferredRdpClient method the store will end up setting preferredRdpClient value as "none".
Oh unless we plan to treat "none" option as null/undefined, then that would make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds handlers to support rdp client launch and select preferred clients
jira- https://hashicorp.atlassian.net/browse/ICU-17876
Screenshots (if appropriate)
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.