-
Notifications
You must be signed in to change notification settings - Fork 295
ICU-14484: redis connect helper #6001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r in docker setup
This reverts commit 2b91529.
…nual testing less tedious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
testing/internal/e2e/tests/base/target_tcp_connect_redis_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming you've manually tested this. I'll let @moduli comment on the new, skipped e2e test before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the state of the e2e test. Hopefully we can come back to this at some point.
@johanbrandhorst Confirming that I've tested it manually (and that it works). Thanks for the help! |
Description
connect redis
helper command. Invokes redis-cli, connecting to the specified targetFor local manual testing:
target_tcp_connect_redis_test.go
(This will leave redis infra set up and available after running the test once.):t.Skip(...)
andreturn
t.Cleanup(...)
commented out)go test github.com/hashicorp/boundary/testing/internal/e2e/tests/base -v -run '^TestCliTcpTargetConnectRedis$'
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.