Skip to content

Conversation

laero
Copy link

@laero laero commented Aug 27, 2025

Description

  • Add connect redis helper command. Invokes redis-cli, connecting to the specified target
  • Update website and docs with info on redis helper
  • e2e test skipped (to-do in a later task). odd behavior between redis-cli / pty preventing us from fully testing it.

For local manual testing:

  • Set up local boundary and auth to it
  • Edit target_tcp_connect_redis_test.go (This will leave redis infra set up and available after running the test once.):
    • comment out t.Skip(...) and return
    • comment in lines 15 - 88 (leave t.Cleanup(...)commented out)
  • Run the redis test: go test github.com/hashicorp/boundary/testing/internal/e2e/tests/base -v -run '^TestCliTcpTargetConnectRedis$'
  • Test connect helper (use target-id provided by running the test above):
❯ boundary connect redis -target-id ttcp_7gF1eSv4tS
127.0.0.1:64469> PING
(error) NOPERM User e2eboundary has no permissions to run the 'ping' command
127.0.0.1:64469> SET A B
OK
127.0.0.1:64469> GET A
"B"
127.0.0.1:64469> QUIT

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Copy link

hashicorp-cla-app bot commented Aug 27, 2025

CLA assistant check
All committers have signed the CLA.

@laero laero added this to the 0.20.x milestone Sep 8, 2025
@laero laero self-assigned this Sep 8, 2025
@laero laero marked this pull request as ready for review September 8, 2025 19:25
@laero laero requested review from a team as code owners September 8, 2025 19:25
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you've manually tested this. I'll let @moduli comment on the new, skipped e2e test before approving.

Copy link
Collaborator

@moduli moduli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the state of the e2e test. Hopefully we can come back to this at some point.

@laero
Copy link
Author

laero commented Sep 9, 2025

LGTM assuming you've manually tested this. I'll let @moduli comment on the new, skipped e2e test before approving.

@johanbrandhorst Confirming that I've tested it manually (and that it works). Thanks for the help!

@laero laero modified the milestones: 0.20.x, 0.21.x Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants