Enhance service deregistration logic for agentless mode #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreeram77
approved these changes
May 9, 2025
magec
pushed a commit
to magec/consul-esm
that referenced
this pull request
Jun 20, 2025
Co-authored-by: srahul3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
agent.gofile to handle service deregistration logic for agentless nodes and adds a new utility method for write options in Consul API interactions. Below is a summary of the most important changes:Enhancements to service deregistration:
Runmethod infunc (a *Agent) Run() errorto include a conditional block for agentless nodes. If the agent is in agentless mode, it now constructs aCatalogDeregistrationobject and attempts to deregister the service using the Consul Catalog API. A warning is logged if the deregistration fails.Utility method addition:
func (a *Agent) ConsulWriteOption() *api.WriteOptions, to generateWriteOptionsfor Consul API calls. This method dynamically sets the partition information if available, improving consistency in API interactions.