Clarify ping_type behavior in ESM configuration #331
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the README documentation to clarify the behavior difference between
ping_type = "udp"
andping_type = "socket"
in the ESM configuration.Key Updates
udp
requires both IP and port, and may silently fail in some environments.socket
uses ICMP and is more reliable for basic node availability.Testing
ping_type = "udp"
does not send pings if port is provided.ping_type = "socket"
correctly sends ICMP pings at configured intervals (10s
).