Skip to content

add: denlylist pattern support #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

add: denlylist pattern support #2062

merged 4 commits into from
Jun 2, 2025

Conversation

dduzgun-security
Copy link
Contributor

@dduzgun-security dduzgun-security commented May 27, 2025 •
edited
Loading

Add support for denylist on glob patterns like sprig_*.

@dduzgun-security dduzgun-security requested a review from a team as a code owner May 27, 2025 22:02
tgross
tgross reviewed May 28, 2025
View reviewed changes
@dduzgun-security dduzgun-security requested a review from tgross May 30, 2025 19:39
tgross
tgross reviewed May 30, 2025
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like depguard doesn't like the import change... that'll need to get fixed.

tgross
tgross approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dduzgun-security
Copy link
Contributor Author

I appreciate the review @tgross. Would need a codeowners ✔️ to squash & merge

srahul3
srahul3 approved these changes Jun 2, 2025
View reviewed changes
Copy link

@srahul3 srahul3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@dduzgun-security dduzgun-security merged commit bcb42d0 into main Jun 2, 2025
53 checks passed
@dduzgun-security dduzgun-security deleted the add/denylist-pattern branch June 2, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross tgross tgross approved these changes

@srahul3 srahul3 srahul3 approved these changes

@Vikramarjuna Vikramarjuna Awaiting requested review from Vikramarjuna

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dduzgun-security @tgross @srahul3