Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templated nomad policies #21872

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tristanmorgan
Copy link
Member

Description

Updated the templated polices to match the recommended in the docs.

Links

https://developer.hashicorp.com/nomad/docs/integrations/consul/acl#nomad-agents
hashicorp/nomad#23802

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Oct 23, 2024
@@ -2,7 +2,7 @@ agent_prefix "" {
policy = "read"
}
node_prefix "" {
policy = "read"
policy = "write"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tristanmorgan Does Nomad register nodes into Consul? I thought it only registered services to existing Consul nodes.

Copy link
Member Author

@tristanmorgan tristanmorgan Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from:

since Consul 1.15 Nomad agents require a node:write policy, and not node:read like our documentation suggests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated policy to limit changes to the named node.

@@ -1,10 +1,12 @@

acl = "write"
acl = "write"
mesh = "write"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do Nomad servers need the mesh:write permission?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from https://developer.hashicorp.com/nomad/docs/integrations/consul/acl#nomad-agents

Nomad servers also create configuration entries for Consul Service Mesh, so the specific permissions vary slightly between Nomad servers and clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants