Skip to content

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 25, 2025

πŸ“Œ Summary

This is a WIP, which contains the porting of previous showcase theming explorations (squashed).

This is based on top of #3259

πŸ› οΈ Detailed description

πŸ‘‰ πŸ‘‰ πŸ‘‰ Preview: theming page

πŸ’¬ To discuss/decide

  • do we want to add hds-theme-system or data-hds-theme="system" when the user-selected option is system?
    • pros: it's clearer what theme is applied, by looking at the HTML
    • cons: it required some work to have the selector work with the :not() selectors (see below)
  • should the _currentStylesheet be stored in local storage or in URL as query param (same for the other shw preferences)?
  • do we want to keep the globalOnSetTheme callback? which use cases do we foresee?

πŸ—’οΈ TODOs

πŸ“Έ Screenshots

πŸ”— External links

Jira tickets:


πŸ‘€ Component checklist

  • Percy was checked for any visual regression

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 21, 2025 1:37pm
hds-website Ready Ready Preview Oct 21, 2025 1:37pm

πŸ’‘ Enable Vercel Agent with $100 free credit for automated AI reviews

@didoo didoo changed the title [WIP] [Project Solaris / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solis / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo changed the title [WIP] [Project Solis / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solar/ Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo changed the title [WIP] [Project Solar/ Phase 1 / Showcase] Add support for theming and theme-switching to the showcase [WIP] [Project Solar / Phase 1 / Showcase] Add support for theming and theme-switching to the showcase Sep 25, 2025
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from b73dbf9 to a4f41dd Compare September 30, 2025 14:11
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from a4f41dd to cc61972 Compare September 30, 2025 14:20
@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch from 519a6a6 to 3863dfa Compare September 30, 2025 14:50
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from cc61972 to 59418c1 Compare September 30, 2025 16:16
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 59418c1 to 2f20cdc Compare September 30, 2025 17:23
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 2f20cdc to 92910be Compare September 30, 2025 17:23
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 92910be to a1ff2f5 Compare September 30, 2025 20:23
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 6a71214 to 0615994 Compare October 21, 2025 10:22
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 0615994 to f4d0128 Compare October 21, 2025 11:43
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch 2 times, most recently from 7a3182c to d7cbfb5 Compare October 21, 2025 11:59
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from d7cbfb5 to 5ca5d3f Compare October 21, 2025 12:57
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 5ca5d3f to 5bfbc9d Compare October 21, 2025 13:06
@didoo didoo force-pushed the project-solar/phase-1/HDS-5242_showcase/add-themes-support branch from 5bfbc9d to 01eae84 Compare October 21, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants