-
Notifications
You must be signed in to change notification settings - Fork 51
CodeBlock
gts conversion
#3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CodeBlock
gts conversion
#3293
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e4b307b
to
ead3099
Compare
|
||
<ShwDivider @level={{2}} /> | ||
|
||
<ShwTextH3>Dynamic content</ShwTextH3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I would make this one a code fragment, just to group the functionality code closer to the template code. But you dont have to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm going to leave it here for now because it's a small block and not reusable. If that's alright.
showcase/app/components/page-components/code-block/sub-sections/demo.gts
Outdated
Show resolved
Hide resolved
ead3099
to
b3f04f0
Compare
📌 Summary
If merged, this PR converts the CodeBlock showcase page to a GTS component.
🔗 External links
Jira ticket: HDS-5336
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.