-
Notifications
You must be signed in to change notification settings - Fork 51
dropdown-list-item-interactive
codemod improvements
#3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dropdown-list-item-interactive
codemod improvements
#3303
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the code, but this requires a changelog entry for the codemods package, otherwise it won't be picked up by changeset for release
@alex-ju My bad, I had forgotten the codemods needed a changeset. Been a minute. Thanks for the reminder. |
📌 Summary
If merged, this PR makes improvements to the
dropdown-list-item-interactive
codemod.🛠️ Detailed description
The codemod was previously unable to handle concatenated values like:
This change allows the codemod to work on these values, resulting in:
🔗 External links
Jira ticket: HDS-4670
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.