Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Oct 14, 2025

📌 Summary

If merged, this PR makes improvements to the dropdown-list-item-interactive codemod.

🛠️ Detailed description

The codemod was previously unable to handle concatenated values like:

<Hds::Dropdown as |dd|>
  <dd.Interactive @href="#" @text="Edit {{this.name}}" />
</Hds::Dropdown>

This change allows the codemod to work on these values, resulting in:

<Hds::Dropdown as |dd|>
  <dd.Interactive @href="#">Edit {{this.name}}</dd.Interactive>
</Hds::Dropdown>

🔗 External links

Jira ticket: HDS-4670


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 15, 2025 2:42pm
hds-website Ready Ready Preview Oct 15, 2025 2:42pm

didoo
didoo previously approved these changes Oct 15, 2025
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the code, but this requires a changelog entry for the codemods package, otherwise it won't be picked up by changeset for release

@zamoore
Copy link
Contributor Author

zamoore commented Oct 15, 2025

Haven't reviewed the code, but this requires a changelog entry for the codemods package, otherwise it won't be picked up by changeset for release

@alex-ju My bad, I had forgotten the codemods needed a changeset. Been a minute. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants