AppFooter Showcase - Convert to GTS (HDS-5326)
#3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
KristinLBradley
changed the title
AppFooter - Convert to GTS (HDS-5326)AppFooter, Showcase - Convert to GTS (HDS-5326)
KristinLBradley
changed the title
AppFooter, Showcase - Convert to GTS (HDS-5326)AppFooter Showcase - Convert to GTS (HDS-5326)
|
Should I break any of the content down more? This is a fairly simple component overall. |
didoo
reviewed
Oct 20, 2025
showcase/app/components/page-components/app-footer/sub-sections/base.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/base.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/base-elements.gts
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/base.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/layout.gts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cristiano Rastelli <[email protected]>
|
@KristinLBradley I see an error now in the Components / Tests: |
@didoo It disappeared after I reran tests |
shleewhite
reviewed
Oct 20, 2025
showcase/app/components/page-components/app-footer/sub-sections/base-elements.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/content.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/layout.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/theme.gts
Outdated
Show resolved
Hide resolved
showcase/app/components/page-components/app-footer/sub-sections/base-elements.gts
Show resolved
Hide resolved
Co-authored-by: Lee White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the
AppFooterShowcase page to GTS format.Preview: https://hds-showcase-git-kristin-hds-5326-app-footer-s-bb3fce-hashicorp.vercel.app/components/app-footer
🔗 External links
👀 Component checklist
[ ] A changelog entry was added via Changesets if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.