-
Notifications
You must be signed in to change notification settings - Fork 51
AppFooter
- Update copyright text (HDS-5553)
#3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
@@ -1 +1 @@ | |||
copyright-text: "© {year} HashiCorp" | |||
copyright-text: "© {year} HashiCorp, an IBM company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem inconsistent, but the difference seems whether it's being used as a noun ("company"), or proper noun "…IBM Company", which to me seems like it should be a proper noun in this context where this is more of a brand/logo recognition question. So "HashiCorp, an IBM Company" seems right. Open to other interpretations, but good catch on the consistency portion. Might be worth calling that out to the folks who manage the website/branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed what was in the ticket which had "company" in lowercase.
https://hashicorp.atlassian.net/browse/HDS-5553
So should I change it to uppercase?
This comment was marked as resolved.
This comment was marked as resolved.
caf8830
to
2fb6d8f
Compare
Co-authored-by: Dylan Hyun <[email protected]>
@KristinLBradley FYI there is already a PR opened by @DanielChenTO #3309 which is still incomplete (see @alex-ju comment here #3309 (review)); can you sync with them and see what is the best way forward to avoid duplicate/conflicting efforts? |
@didoo I added a comment suggesting that they close their PR in favor of this one. |
📌 Summary
If merged, this PR updates the
AppFooter
copyright text from "HashiCorp" to "HashiCorp, an IBM company"Preview: https://hds-showcase-git-hds-5553-app-footer-copyright-update-hashicorp.vercel.app/components/app-footer
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.