Skip to content

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Oct 20, 2025

📌 Summary

If merged, this PR updates the AppFooter copyright text from "HashiCorp" to "HashiCorp, an IBM company"

Preview: https://hds-showcase-git-hds-5553-app-footer-copyright-update-hashicorp.vercel.app/components/app-footer

🔗 External links


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 20, 2025 6:59pm
hds-website Ready Ready Preview Oct 20, 2025 6:59pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@@ -1 +1 @@
copyright-text: "© {year} HashiCorp"
copyright-text: "© {year} HashiCorp, an IBM company"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Is "company" supposed to be capitalized? I've seen it done both ways in our comms. It seems it's a bit inconsistent. My hunch would be not capitalized, but just want to raise it so we can be sure.

Image Image Image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem inconsistent, but the difference seems whether it's being used as a noun ("company"), or proper noun "…IBM Company", which to me seems like it should be a proper noun in this context where this is more of a brand/logo recognition question. So "HashiCorp, an IBM Company" seems right. Open to other interpretations, but good catch on the consistency portion. Might be worth calling that out to the folks who manage the website/branding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed what was in the ticket which had "company" in lowercase.
https://hashicorp.atlassian.net/browse/HDS-5553

So should I change it to uppercase?

@KristinLBradley

This comment was marked as resolved.

@KristinLBradley KristinLBradley force-pushed the hds-5553-app-footer-copyright-update branch from caf8830 to 2fb6d8f Compare October 20, 2025 20:09
@didoo
Copy link
Contributor

didoo commented Oct 20, 2025

@KristinLBradley FYI there is already a PR opened by @DanielChenTO #3309 which is still incomplete (see @alex-ju comment here #3309 (review)); can you sync with them and see what is the best way forward to avoid duplicate/conflicting efforts?

@KristinLBradley
Copy link
Contributor Author

@KristinLBradley FYI there is already a PR opened by @DanielChenTO #3309 which is still incomplete (see @alex-ju comment here #3309 (review)); can you sync with them and see what is the best way forward to avoid duplicate/conflicting efforts?

@didoo I added a comment suggesting that they close their PR in favor of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants